From 2af9a8635ddb506dd620becf1b7a3a3e4c0c9a16 Mon Sep 17 00:00:00 2001 From: Kushal Munir < kmunir@ca.ibm.com> Date: Tue, 5 Dec 2006 01:20:55 +0000 Subject: [PATCH] [cleanup] fix compiler warnings --- .../ui/actions/SystemBaseSubMenuAction.java | 24 ++++++++++--------- .../propertypages/SystemBasePropertyPage.java | 13 +++++----- .../ui/view/ISystemViewDropDestination.java | 6 ++--- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseSubMenuAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseSubMenuAction.java index 9fdff8395b5..662997f000c 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseSubMenuAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseSubMenuAction.java @@ -53,7 +53,7 @@ public abstract class SystemBaseSubMenuAction * @param label * @param tooltip * @param image The image to display for this action - * @param shell The owning shell. If you pass null now, be sure to call setShell later + * @param shell the parent shell. If you pass null now, be sure to call {@link #setShell(Shell)} later. * * @deprecated use fields from resource class directly now instead of via ResourceBundle */ @@ -67,8 +67,8 @@ public abstract class SystemBaseSubMenuAction /** * Constructor for SystemBaseSubMenuAction when there is just a string - * @param label The label to display - * @param parent The owning shell. If you pass null now, be sure to call setShell later + * @param label the label to display. + * @param shell the parent shell. If you pass null now, be sure to call {@link #setShell(Shell)} later. */ protected SystemBaseSubMenuAction(String label, Shell shell) { @@ -78,9 +78,9 @@ public abstract class SystemBaseSubMenuAction } /** * Constructor for SystemBaseSubMenuAction when there is just a string - * @param label The label to display - * @param tooltip The tooltip to display - * @param parent The owning shell. If you pass null now, be sure to call setShell later + * @param label the label to display. + * @param tooltip the tooltip to display. + * @param shell the parent shell. If you pass null now, be sure to call {@link #setShell(Shell)} later. */ protected SystemBaseSubMenuAction(String label, String tooltip, Shell shell) { @@ -90,8 +90,9 @@ public abstract class SystemBaseSubMenuAction } /** * Constructor for SystemBaseSubMenuAction when there is just a string and image - * @param label The label to display - * @param parent The owning shell. If you pass null now, be sure to call setShell later + * @param label the label to display. + * @param image the image descriptor for the action. + * @param shell the parent shell. If you pass null now, be sure to call {@link #setShell(Shell)} later. */ protected SystemBaseSubMenuAction(String label, ImageDescriptor image, Shell shell) { @@ -102,9 +103,10 @@ public abstract class SystemBaseSubMenuAction /** * Constructor for SystemBaseSubMenuAction when there is just a string and image - * @param label The label to display - * @param tooltip the tooltip to display - * @param parent The owning shell. If you pass null now, be sure to call setShell later + * @param label the label to display. + * @param tooltip the tooltip to display. + * @param image the image descriptor for the action. + * @param shell the parent shell. If you pass null now, be sure to call {@link #setShell(Shell)} later. */ protected SystemBaseSubMenuAction(String label, String tooltip, ImageDescriptor image, Shell shell) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemBasePropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemBasePropertyPage.java index 3688d52907e..c7bc3ca0cc9 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemBasePropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemBasePropertyPage.java @@ -30,6 +30,7 @@ import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; +import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Text; import org.eclipse.ui.dialogs.PropertyPage; @@ -132,7 +133,7 @@ public abstract class SystemBasePropertyPage extends PropertyPage /** * For setting the default overall help for the dialog. - * This can be overridden per control by calling {@link #setHelp(Control, String)}. + * This can be overridden per control by calling {@link SystemWidgetHelpers#setHelp(Control, String)} */ public void setHelp(String helpId) { @@ -241,7 +242,7 @@ public abstract class SystemBasePropertyPage extends PropertyPage *

* Subclasses should override to do full error checking on all the widgets on the page. Recommendation:
*

* @@ -362,7 +363,7 @@ public abstract class SystemBasePropertyPage extends PropertyPage /** * Create a labeled label, where the label on the right grabs excess space and has an indent so it * isn't smashed up against the prompt on the left. - * @see SystemWidgetHelpers#createLabeledLabel(Composite, ResourceBundle, String, boolean) + * @see SystemWidgetHelpers#createLabeledLabel(Composite, String, String, boolean) * @see #grabExcessSpace(Control) */ protected Label createLabeledLabel(Composite c, String label, String tooltip) @@ -379,7 +380,7 @@ public abstract class SystemBasePropertyPage extends PropertyPage /** * Create a labeled combo, where the combo on the right grabs excess space and has an indent so it * isn't smashed up against the prompt on the left. - * @see SystemWidgetHelpers#createLabeledCombo(Composite, Listener, ResourceBundle, String) + * @see SystemWidgetHelpers#createLabeledCombo(Composite, Listener, String, String) * @see #grabExcessSpace(Control) */ protected Combo createLabeledCombo(Composite c, String label, String tooltip) @@ -396,7 +397,7 @@ public abstract class SystemBasePropertyPage extends PropertyPage /** * Create a labeled entry field, where the field on the right grabs excess space and has an indent so it * isn't smashed up against the prompt on the left. - * @see SystemWidgetHelpers#createLabeledTextField(Composite, Listener, ResourceBundle, String) + * @see SystemWidgetHelpers#createLabeledTextField(Composite, Listener, String, String) * @see #grabExcessSpace(Control) */ protected Text createLabeledText(Composite c, String label, String tooltip) @@ -413,7 +414,7 @@ public abstract class SystemBasePropertyPage extends PropertyPage /** * Create a labeled verbage field, where the field on the right grabs excess space and has an indent so it * isn't smashed up against the prompt on the left. - * @see SystemWidgetHelpers#createLabeledTextField(Composite, Listener, ResourceBundle, String) + * @see SystemWidgetHelpers#createLabeledTextField(Composite, Listener, String, String) * @see #grabExcessSpace(Control) */ protected Label createLabeledVerbage(Composite c, String label, String tooltip) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/ISystemViewDropDestination.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/ISystemViewDropDestination.java index 68f2a83d21e..8296273d474 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/ISystemViewDropDestination.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/ISystemViewDropDestination.java @@ -26,9 +26,9 @@ public interface ISystemViewDropDestination { /** - * ask source adapter if it supports drop of its type on this target - * @param resource (type) in question - * @return true if copy/move/drop is supported + * Asks source adapter whether it supports dropping it on the given target. + * @param target the target to drop to. + * @return true if the drop destination is supported, false otherwise. */ public boolean supportDropDestination(Object target); } \ No newline at end of file