From 2ad64ddcdd2d2df1c9b23b13656edb396a05af7e Mon Sep 17 00:00:00 2001
From: Michael Scharf <Michael.Scharf@windriver.com>
Date: Wed, 3 Oct 2007 01:05:11 +0000
Subject: [PATCH] bug 199285: [terminal][api] TerminalConnector ID should be
 mandatory in plugin.xml https://bugs.eclipse.org/bugs/show_bug.cgi?id=199285

---
 terminal/org.eclipse.tm.terminal.serial/plugin.xml        | 4 +++-
 terminal/org.eclipse.tm.terminal.ssh/plugin.xml           | 4 +++-
 terminal/org.eclipse.tm.terminal.telnet/plugin.xml        | 4 +++-
 .../org.eclipse.tm.terminal/schema/terminalConnector.exsd | 8 ++++----
 4 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/terminal/org.eclipse.tm.terminal.serial/plugin.xml b/terminal/org.eclipse.tm.terminal.serial/plugin.xml
index 7c62d8dd123..a7578808e5c 100644
--- a/terminal/org.eclipse.tm.terminal.serial/plugin.xml
+++ b/terminal/org.eclipse.tm.terminal.serial/plugin.xml
@@ -14,6 +14,8 @@
 <plugin>
    <extension
          point="org.eclipse.tm.terminal.terminalConnector">
-      <connector name="%serialConnection" class="org.eclipse.tm.internal.terminal.serial.SerialConnector"/>
+      <connector name="%serialConnection" 
+      id="org.eclipse.tm.internal.terminal.serial.SerialConnector"
+      class="org.eclipse.tm.internal.terminal.serial.SerialConnector"/>
    </extension>
 </plugin>
diff --git a/terminal/org.eclipse.tm.terminal.ssh/plugin.xml b/terminal/org.eclipse.tm.terminal.ssh/plugin.xml
index fcf13b1a3a0..193d10b1e10 100644
--- a/terminal/org.eclipse.tm.terminal.ssh/plugin.xml
+++ b/terminal/org.eclipse.tm.terminal.ssh/plugin.xml
@@ -14,7 +14,9 @@
 <plugin>
    <extension
          point="org.eclipse.tm.terminal.terminalConnector">
-      <connector name="%sshConnection" class="org.eclipse.tm.internal.terminal.ssh.SshConnector"/>
+      <connector name="%sshConnection"
+      id="org.eclipse.tm.internal.terminal.ssh.SshConnector"
+      class="org.eclipse.tm.internal.terminal.ssh.SshConnector"/>
    </extension>
 
 </plugin>
diff --git a/terminal/org.eclipse.tm.terminal.telnet/plugin.xml b/terminal/org.eclipse.tm.terminal.telnet/plugin.xml
index 480e9168612..d307c988764 100644
--- a/terminal/org.eclipse.tm.terminal.telnet/plugin.xml
+++ b/terminal/org.eclipse.tm.terminal.telnet/plugin.xml
@@ -14,6 +14,8 @@
 <plugin>
    <extension
          point="org.eclipse.tm.terminal.terminalConnector">
-      <connector name="%telnetConnection" class="org.eclipse.tm.internal.terminal.telnet.TelnetConnector"/>
+      <connector name="%telnetConnection"
+      id="org.eclipse.tm.internal.terminal.telnet.TelnetConnector"
+      class="org.eclipse.tm.internal.terminal.telnet.TelnetConnector"/>
    </extension>
 </plugin>
diff --git a/terminal/org.eclipse.tm.terminal/schema/terminalConnector.exsd b/terminal/org.eclipse.tm.terminal/schema/terminalConnector.exsd
index 8da38f0552c..fcae9c202c8 100644
--- a/terminal/org.eclipse.tm.terminal/schema/terminalConnector.exsd
+++ b/terminal/org.eclipse.tm.terminal/schema/terminalConnector.exsd
@@ -44,20 +44,20 @@
 
    <element name="connector">
       <complexType>
-         <attribute name="class" type="string">
+         <attribute name="class" type="string" use="required">
             <annotation>
                <documentation>
-                  
+                  A class implementing ITerminalConnector
                </documentation>
                <appInfo>
                   <meta.attribute kind="java" basedOn="org.eclipse.tm.internal.terminal.provisional.api.ITerminalConnector"/>
                </appInfo>
             </annotation>
          </attribute>
-         <attribute name="id" type="string">
+         <attribute name="id" type="string" use="required">
             <annotation>
                <documentation>
-                  
+                  Uniquely identify this connector
                </documentation>
             </annotation>
          </attribute>