mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

[214956] [Memory View] Memory View workflow enhancements: quick address navigation; simplified use defaults; fewer clicks

Browse source
This commit is contained in:
Ted Williams 2008-09-01 02:27:55 +00:00
parent 6958d0987f
commit 2ad6225eb4
1 changed files with 45 additions and 98 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

137
plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/traditional/TraditionalGoToAddressRendering.java
View file

@ -96,116 +96,63 @@ public class TraditionalGoToAddressRendering extends AbstractMemoryRendering {
} }
IMemoryRenderingContainer containers[] = fSite.getMemoryRenderingContainers(); IMemoryRenderingContainer containers[] = fSite.getMemoryRenderingContainers();
IMemoryRenderingContainer firstRenderingViewPane = null;
for(int i = 0; i < containers.length; i++) for(int i = 0; i < containers.length; i++)
{ {
if(containers[i] instanceof RenderingViewPane) if(containers[i] instanceof RenderingViewPane)
{ {
firstRenderingViewPane = containers[i]; BigInteger absoluteAddress = null;
break; if(fGotoAddress.isGoToAddress())
} absoluteAddress = address;
}
BigInteger absoluteAddress = null; IMemoryBlock activeMemoryBlock = null;
if(fGotoAddress.isGoToAddress())
absoluteAddress = address;
IMemoryBlock activeMemoryBlock = null; if(address != null && containers[i] != null)
if(address != null && firstRenderingViewPane != null)
{
IMemoryRendering activeRendering = firstRenderingViewPane.getActiveRendering();
if(activeRendering != null)
{
activeMemoryBlock = activeRendering.getMemoryBlock();
IMemoryBlockExtension blockExtension = (IMemoryBlockExtension) activeMemoryBlock.getAdapter(IMemoryBlockExtension.class);
if(blockExtension != null)
{ {
BigInteger baseAddress = null; IMemoryRendering activeRendering = containers[i].getActiveRendering();
BigInteger addressableSize = null; if(activeRendering != null)
try
{ {
baseAddress = blockExtension.getBigBaseAddress(); activeMemoryBlock = activeRendering.getMemoryBlock();
addressableSize = BigInteger.valueOf(blockExtension.getAddressableSize()); IMemoryBlockExtension blockExtension = (IMemoryBlockExtension) activeMemoryBlock.getAdapter(IMemoryBlockExtension.class);
} if(blockExtension != null)
catch(DebugException de) {
{ BigInteger baseAddress = null;
// TODO BigInteger addressableSize = null;
} try
{
baseAddress = blockExtension.getBigBaseAddress();
addressableSize = BigInteger.valueOf(blockExtension.getAddressableSize());
}
catch(DebugException de)
{
// TODO
}
if(baseAddress != null) if(baseAddress != null)
{ {
if(fGotoAddress.isOffset()) if(fGotoAddress.isOffset())
absoluteAddress = baseAddress.add(address); absoluteAddress = baseAddress.add(address);
else if(fGotoAddress.isJump() && addressableSize != null) else if(fGotoAddress.isJump() && addressableSize != null)
absoluteAddress = baseAddress.add(address.multiply(addressableSize)); absoluteAddress = baseAddress.add(address.multiply(addressableSize));
} }
} }
// 1) Try to reposition the renderings using the IRepositionableMemoryRendering interface // 1) Try to reposition the renderings using the IRepositionableMemoryRendering interface
if(absoluteAddress != null && activeRendering instanceof IRepositionableMemoryRendering) if(absoluteAddress != null && activeRendering instanceof IRepositionableMemoryRendering)
{ {
try try
{ {
((IRepositionableMemoryRendering) activeRendering).goToAddress(absoluteAddress); ((IRepositionableMemoryRendering) activeRendering).goToAddress(absoluteAddress);
return; }
} catch(DebugException de)
catch(DebugException de) {
{ // do nothing
// TODO ? }
}
} }
} }
} }
} }
// 2) Fallback: Remove existing memory block; Add new memory block
IMemoryBlockRetrieval retrieval = MemoryViewUtil.getMemoryBlockRetrieval(DebugUITools.getDebugContext());
final BigInteger absoluteAddressFinal = absoluteAddress;
final IMemoryBlock activeMemoryBlockFinal = activeMemoryBlock;
final IMemoryBlockRetrieval retrievalFinal = retrieval;
if(retrieval instanceof IMemoryBlockRetrievalExtension)
{
String absoluteAddressExpression = fGotoAddress.getExpressionText();
if(absoluteAddressFinal != null)
absoluteAddressExpression = (radix == 16 ? "0x" : "") + absoluteAddressFinal.toString(radix);
final String absoluteAddressExpressionFinal = absoluteAddressExpression;
new Thread() { // upgrade to Job ?
public void run()
{
try
{
final IMemoryBlockExtension memBlock = ((IMemoryBlockRetrievalExtension) retrievalFinal)
.getExtendedMemoryBlock(absoluteAddressExpressionFinal, DebugUITools.getDebugContext());
if (memBlock != null)
{
Display.getDefault().asyncExec(new Runnable(){
public void run()
{
IMemoryRenderingContainer container = fSite.getContainer(IDebugUIConstants.ID_RENDERING_VIEW_PANE_1);
IMemoryRendering createRendering = new CreateRendering(container);
createRendering.init(container, memBlock);
container.addMemoryRendering(createRendering);
}
});
}
else
{
// open error if it failed to retrieve a memory block
MemoryViewUtil.openError(DebugUIMessages.AddMemoryBlockAction_title, DebugUIMessages.AddMemoryBlockAction_noMemoryBlock, null);
}
}
catch(DebugException de)
{
MemoryViewUtil.openError(DebugUIMessages.AddMemoryBlockAction_title, DebugUIMessages.AddMemoryBlockAction_noMemoryBlock, de);
}
}
}.start();
}
} }
}; };