mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-04 23:55:26 +02:00
Code Issues Wiki Activity

Terminal: Fix control decoration not hidden if data becomes valid

Browse source
This commit is contained in:
Uwe Stieber 2013-01-08 09:21:27 +01:00
parent b13053defb
commit 27df9b1096
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
plugins/org.eclipse.tm.terminal.ssh/src/org/eclipse/tm/internal/terminal/ssh/SshSettingsPage.java
View file

@ -73,14 +73,18 @@ public class SshSettingsPage extends AbstractSettingsPage {
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fHostText, null, IMessageProvider.NONE);
}
if (fUser.getText().trim().length() == 0) {
String m = "Please enter a username."; //$NON-NLS-1$
int mt = IMessageProvider.INFORMATION;
updateControlDecoration(fHostText, m, mt);
updateControlDecoration(fUser, m, mt);
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fUser, null, IMessageProvider.NONE);
}
try {
int p = Integer.parseInt(fPort.getText().trim());
@ -91,6 +95,8 @@ public class SshSettingsPage extends AbstractSettingsPage {
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fPort, null, IMessageProvider.NONE);
}
p = Integer.parseInt(fTimeout.getText().trim());
if (p < 0) {
@ -100,15 +106,19 @@ public class SshSettingsPage extends AbstractSettingsPage {
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fTimeout, null, IMessageProvider.NONE);
}
p = Integer.parseInt(fKeepalive.getText().trim());
if (p < 0) {
String m = "Invalid keep alive. Must be greater than 0."; //$NON-NLS-1$
int mt = IMessageProvider.ERROR;
updateControlDecoration(fTimeout, m, mt);
updateControlDecoration(fKeepalive, m, mt);
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fKeepalive, null, IMessageProvider.NONE);
}
} catch (Exception e) {
valid = false;

6
plugins/org.eclipse.tm.terminal.telnet/src/org/eclipse/tm/internal/terminal/telnet/TelnetSettingsPage.java
View file

@ -106,6 +106,8 @@ public class TelnetSettingsPage extends AbstractSettingsPage {
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fHostText, null, IMessageProvider.NONE);
}
try {
@ -117,6 +119,8 @@ public class TelnetSettingsPage extends AbstractSettingsPage {
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fNetworkPortCombo, null, IMessageProvider.NONE);
}
p = Integer.parseInt(fTimeout.getText().trim());
@ -127,6 +131,8 @@ public class TelnetSettingsPage extends AbstractSettingsPage {
if (mt > messageType) { message = m; messageType = mt; }
valid = false;
} else {
updateControlDecoration(fTimeout, null, IMessageProvider.NONE);
}
} catch (Exception e) {