mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 17:56:01 +02:00
Code Issues Wiki Activity

Opimization to getExtendedMemoryBlock(). Where the expression is an absolute address (decimal or hex value), we can sidestep a lot of processing--no need to get the backend to resolve the expression as there is really nothing to resolve.

Browse source
This commit is contained in:
John Cortell 2007-01-18 02:04:39 +00:00
parent a89ed5cff7
commit 273a31b365
1 changed files with 22 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CMemoryBlockRetrievalExtension.java
View file

@ -146,6 +146,23 @@ public class CMemoryBlockRetrievalExtension extends PlatformObject implements IM
try { try {
if (selected instanceof IDebugElement) { if (selected instanceof IDebugElement) {
IDebugElement debugElement = (IDebugElement)selected; IDebugElement debugElement = (IDebugElement)selected;
IDebugTarget target = debugElement.getDebugTarget();
if (!(target instanceof CDebugTarget)) {
throw new DebugException( new Status( IStatus.ERROR, CDebugCorePlugin.getUniqueIdentifier(), DebugException.REQUEST_FAILED, msg, null ) );
}
// See if the expression is a simple numeric value; if it is, we can avoid some costly
// processing (calling the backend to resolve the expression)
try {
if (expression.startsWith("0x") && expression.length() > 2) {
return new CMemoryBlockExtension((CDebugTarget)target, expression, new BigInteger(expression.substring(2), 16));
} else if (Character.isDigit(expression.charAt(0))) {
return new CMemoryBlockExtension((CDebugTarget)target, expression, new BigInteger(expression));
}
} catch (NumberFormatException nfexc) {
// OK, expression is not a simple, absolute numeric value; keep trucking and try to resolve as expression
}
CStackFrame frame = getStackFrame( debugElement ); CStackFrame frame = getStackFrame( debugElement );
if ( frame != null ) { if ( frame != null ) {
// We need to provide a better way for retrieving the address of expression // We need to provide a better way for retrieving the address of expression
@ -157,13 +174,10 @@ public class CMemoryBlockRetrievalExtension extends PlatformObject implements IM
if ( type != null && (type.isPointer() || type.isIntegralType()) ) { if ( type != null && (type.isPointer() || type.isIntegralType()) ) {
address = value.getValueString(); address = value.getValueString();
exp.dispose(); exp.dispose();
IDebugTarget target = debugElement.getDebugTarget(); if ( address != null ) {
if ( target instanceof CDebugTarget ) { // ???
if ( address != null ) { BigInteger a = ( address.startsWith( "0x" ) ) ? new BigInteger( address.substring( 2 ), 16 ) : new BigInteger( address ); //$NON-NLS-1$
// ??? return new CMemoryBlockExtension( (CDebugTarget)target, expression, a );
BigInteger a = ( address.startsWith( "0x" ) ) ? new BigInteger( address.substring( 2 ), 16 ) : new BigInteger( address ); //$NON-NLS-1$
return new CMemoryBlockExtension( (CDebugTarget)target, expression, a );
}
} }
} }
else { else {