mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 06:02:11 +02:00
Code Issues Wiki Activity

Bug 489501 - [memory] Add API to resolve the default memory space id

Browse source 
When using memory spaces, a backend may sometimes qualify an address
to specify the memory space to which the address belongs.  However, to
minimize impacts, the memory space qualifier may not always be present.
In such cases, the address is implied to belong to the "default" memory
space.

DSF-GDB currently has no means to know what is the "default" memory
space to apply in such cases.

This change introduces a new API to request the default memory space
from the memory service.

Change-Id: Icea87543b8529756aee92c6d2af95fb936f5fb9c
This commit is contained in:
Alvaro Sanchez-Leon 2016-02-22 21:42:48 +01:00 • committed by Gerrit Code Review @ Eclipse.org
parent f9d3a184aa
commit 2655b4a0f3
2 changed files with 28 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dsf/org.eclipse.cdt.dsf/.settings/.api_filters
View file

@ -8,4 +8,12 @@
</message_arguments>
</filter>
</resource>
<resource path="src/org/eclipse/cdt/dsf/debug/service/IMemorySpaces.java" type="org.eclipse.cdt.dsf.debug.service.IMemorySpaces">
<filter id="403804204">
<message_arguments>
<message_argument value="org.eclipse.cdt.dsf.debug.service.IMemorySpaces"/>
<message_argument value="getDefaultMemorySpace(IDMContext, DataRequestMonitor&lt;String&gt;)"/>
</message_arguments>
</filter>
</resource>
</component>

20
dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/IMemorySpaces.java
View file

@ -103,4 +103,24 @@ public interface IMemorySpaces extends IDsfService{
* select a memory space when being prompted for a memory location.
*/
public boolean creatingBlockRequiresMemorySpaceID();
/**
* Provides the default memory space to be used in the given context.
*
* @param ctx
* a context which might <i>contain</i> one or more memory
* spaces. Contexts that may be <i>associated</i> with a memory
* space should not be passed in. E.g., an expression might be
* associated with a memory space, but it does not contain memory
* spaces, and is thus not an appropriate context for this
* method.
* @param rm
* the asynchronous data request monitor. Returns a memory space ID.
* Never null, but may be empty.
* @since 2.7
*/
default void getDefaultMemorySpace(IDMContext context, final DataRequestMonitor<String> rm) {
rm.setData(""); //$NON-NLS-1$
rm.done();
}
}