From 25cfe4b60bd9a9ff05e3da745d41b6ef39a7f6db Mon Sep 17 00:00:00 2001 From: David McKnight Date: Tue, 7 Sep 2010 17:51:05 +0000 Subject: [PATCH] [323299] [files] remote file view adapter needs to use the latest version of IRemoteFile -removed synchronize block to avoid any deadlock risk --- .../internal/files/ui/view/SystemViewRemoteFileAdapter.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java index 350f617c5e3..4461805d5e7 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteFileAdapter.java @@ -761,7 +761,11 @@ public class SystemViewRemoteFileAdapter } } - synchronized (file){ + // taking out the synchronized block to avoid potential deadlock + // TODO next release, find a risk-free way to avoid duplicate queries + // synchronized (file) + + { boolean hasChildren = file.hasContents(RemoteChildrenContentsType.getInstance(), filter); if (hasChildren && !file.isStale())