1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 18:26:01 +02:00

Fix for bug 49061: Different values are used as default for the "Load shared library symbols automatically" option.

This commit is contained in:
Mikhail Khodjaiants 2003-12-17 22:16:41 +00:00
parent 67ad10a37b
commit 2450aa42da
7 changed files with 33 additions and 8 deletions

View file

@ -1,3 +1,12 @@
2003-12-17 Mikhail Khodjaiants
Fix for bug 49061: Different values are used as default for the "Load shared library symbols automatically" option.
* src/org/eclipse/cdt/debug/mi/core/GDBDebugger.java
* src/org/eclipse/cdt/debug/mi/core/GDBServerDebugger.java
* src/org/eclipse/cdt/debug/mi/core/IMILaunchConfigurationConstants.java
* src/org/eclipse/cdt/debug/mi/core/CygwinGDBDebugger.java
2003-12-16 Mikhail Khodjaiants 2003-12-16 Mikhail Khodjaiants
Show the gdb arguments when tracing. Show the gdb arguments when tracing.

View file

@ -36,7 +36,7 @@ public class CygwinGDBDebugger extends GDBDebugger {
if (manager instanceof SharedLibraryManager) { if (manager instanceof SharedLibraryManager) {
SharedLibraryManager mgr = (SharedLibraryManager) manager; SharedLibraryManager mgr = (SharedLibraryManager) manager;
boolean stopOnSolibEvents = boolean stopOnSolibEvents =
config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, false); config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, IMILaunchConfigurationConstants.DEBUGGER_STOP_ON_SOLIB_EVENTS_DEFAULT);
try { try {
mgr.setStopOnSolibEvents(stopOnSolibEvents); mgr.setStopOnSolibEvents(stopOnSolibEvents);
// By default, we provide with the capability of deferred breakpoints // By default, we provide with the capability of deferred breakpoints

View file

@ -27,8 +27,8 @@ public class GDBDebugger implements ICDebugger {
ICDISharedLibraryManager manager = session.getSharedLibraryManager(); ICDISharedLibraryManager manager = session.getSharedLibraryManager();
if (manager instanceof SharedLibraryManager) { if (manager instanceof SharedLibraryManager) {
SharedLibraryManager mgr = (SharedLibraryManager)manager; SharedLibraryManager mgr = (SharedLibraryManager)manager;
boolean autolib = config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, false); boolean autolib = config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, IMILaunchConfigurationConstants.DEBUGGER_AUTO_SOLIB_DEFAULT);
boolean stopOnSolibEvents = config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, false); boolean stopOnSolibEvents = config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, IMILaunchConfigurationConstants.DEBUGGER_STOP_ON_SOLIB_EVENTS_DEFAULT);
try { try {
mgr.setAutoLoadSymbols(autolib); mgr.setAutoLoadSymbols(autolib);
mgr.setStopOnSolibEvents(stopOnSolibEvents); mgr.setStopOnSolibEvents(stopOnSolibEvents);

View file

@ -38,7 +38,7 @@ public class GDBServerDebugger implements ICDebugger {
try { try {
ICDISharedLibraryManager mgr = session.getSharedLibraryManager(); ICDISharedLibraryManager mgr = session.getSharedLibraryManager();
if (mgr instanceof SharedLibraryManager) { if (mgr instanceof SharedLibraryManager) {
boolean autolib = config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, false); boolean autolib = config.getAttribute(IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, IMILaunchConfigurationConstants.DEBUGGER_AUTO_SOLIB_DEFAULT);
try { try {
((SharedLibraryManager)mgr).setAutoLoadSymbols(autolib); ((SharedLibraryManager)mgr).setAutoLoadSymbols(autolib);
} catch (CDIException e) { } catch (CDIException e) {

View file

@ -33,4 +33,14 @@ public interface IMILaunchConfigurationConstants {
* Launch configuration attribute key. The value is a List (array of String) of directories for the search path of shared libraries. * Launch configuration attribute key. The value is a List (array of String) of directories for the search path of shared libraries.
*/ */
public static final String ATTR_DEBUGGER_SOLIB_PATH = MIPlugin.getUniqueIdentifier() + ".SOLIB_PATH"; //$NON-NLS-1$ public static final String ATTR_DEBUGGER_SOLIB_PATH = MIPlugin.getUniqueIdentifier() + ".SOLIB_PATH"; //$NON-NLS-1$
/**
* Launch configuration attribute value. The key is ATTR_DEBUGGER_AUTO_SOLIB.
*/
public static boolean DEBUGGER_AUTO_SOLIB_DEFAULT = true;
/**
* Launch configuration attribute value. The key is ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS.
*/
public static boolean DEBUGGER_STOP_ON_SOLIB_EVENTS_DEFAULT = false;
} }

View file

@ -1,3 +1,7 @@
2003-12-17 Mikhail Khodjaiants
Fix for bug 49061: Different values are used as default for the "Load shared library symbols automatically" option.
* GDBSolibBlock.java
2003-12-01 Mikhail Khodjaiants 2003-12-01 Mikhail Khodjaiants
Fix for PR 47230: Need a shared library search path editing capability for GDBServerDebugger. Fix for PR 47230: Need a shared library search path editing capability for GDBServerDebugger.
Implemented 'GDBServerDebuggerPage' as an extension of 'GDBDebuggerPage'. Implemented 'GDBServerDebuggerPage' as an extension of 'GDBDebuggerPage'.

View file

@ -90,9 +90,9 @@ public class GDBSolibBlock extends Observable implements Observer
try try
{ {
if ( fAutoSoLibButton != null ) if ( fAutoSoLibButton != null )
fAutoSoLibButton.setSelection( configuration.getAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, true ) ); fAutoSoLibButton.setSelection( configuration.getAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, IMILaunchConfigurationConstants.DEBUGGER_AUTO_SOLIB_DEFAULT ) );
if ( fStopOnSolibEventsButton != null ) if ( fStopOnSolibEventsButton != null )
fStopOnSolibEventsButton.setSelection( configuration.getAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, false ) ); fStopOnSolibEventsButton.setSelection( configuration.getAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, IMILaunchConfigurationConstants.DEBUGGER_STOP_ON_SOLIB_EVENTS_DEFAULT ) );
initializeButtons( configuration ); initializeButtons( configuration );
updateButtons(); updateButtons();
} }
@ -124,8 +124,10 @@ public class GDBSolibBlock extends Observable implements Observer
{ {
if ( fSolibSearchPathBlock != null ) if ( fSolibSearchPathBlock != null )
fSolibSearchPathBlock.setDefaults( configuration ); fSolibSearchPathBlock.setDefaults( configuration );
configuration.setAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB, true ); configuration.setAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_AUTO_SOLIB,
configuration.setAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS, false ); IMILaunchConfigurationConstants.DEBUGGER_AUTO_SOLIB_DEFAULT );
configuration.setAttribute( IMILaunchConfigurationConstants.ATTR_DEBUGGER_STOP_ON_SOLIB_EVENTS,
IMILaunchConfigurationConstants.DEBUGGER_STOP_ON_SOLIB_EVENTS_DEFAULT );
} }
protected void updateButtons() protected void updateButtons()