From 2443cfbeff09abee51b95703d8e88f1d1af28446 Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Tue, 18 May 2021 13:41:15 -0400 Subject: [PATCH] Bug 572880: Display an ellipsis if opcode is wider than column Instead of silently having opcode bytes not display, show an ellipsis in the last column of the opcodes if the length required for that line is too long. Change-Id: If1379846c2dd7111324933c2bd72244f6abade02 --- .../debug/internal/ui/disassembly/OpcodeRulerColumn.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/OpcodeRulerColumn.java b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/OpcodeRulerColumn.java index 8652900b26a..417650219eb 100644 --- a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/OpcodeRulerColumn.java +++ b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/OpcodeRulerColumn.java @@ -55,7 +55,11 @@ public class OpcodeRulerColumn extends DisassemblyRulerColumn { if (pos instanceof DisassemblyPosition && pos.length > 0 && pos.offset == offset && pos.fValid) { DisassemblyPosition disassPos = (DisassemblyPosition) pos; if (disassPos.fRawOpcode != null) { - return disassPos.fRawOpcode; + if (disassPos.fRawOpcode.length() > nChars) { + return disassPos.fRawOpcode.substring(0, nChars - 1) + "…"; //$NON-NLS-1$ + } else { + return disassPos.fRawOpcode; + } } } else if (pos != null && !pos.fValid) { return DOTS.substring(0, nChars);