mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-13 19:25:38 +02:00
Code Issues Wiki Activity

Restore completion filter after testing preference

Browse source 
On GitHub actions the org.eclipse.cdt.ui.tests.text.contentassist2
tests are running after ProposalFilterPreferencesTest and
ProposalFilterPreferencesTest was changing the default
filter and not restoring it.

Part of #117
This commit is contained in:
Jonah Graham 2022-10-25 13:26:27 -04:00
parent d345323f49
commit 23d44d05a4
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist/ProposalFilterPreferencesTest.java
View file

@ -27,6 +27,22 @@ import junit.framework.TestCase;
*/ */
public class ProposalFilterPreferencesTest extends TestCase { public class ProposalFilterPreferencesTest extends TestCase {
private IPreferenceStore store;
private String filterComboStateStringBefore;
@Override
protected void setUp() throws Exception {
super.setUp();
store = CUIPlugin.getDefault().getPreferenceStore();
filterComboStateStringBefore = store.getString(ContentAssistPreference.PROPOSALS_FILTER);
}
@Override
protected void tearDown() throws Exception {
store.setValue(ContentAssistPreference.PROPOSALS_FILTER, filterComboStateStringBefore);
super.tearDown();
}
public void testPreferences() { public void testPreferences() {
// Check that the test filter is among the filter names. // Check that the test filter is among the filter names.
String[] filterNames = ProposalFilterPreferencesUtil.getProposalFilterNames(); String[] filterNames = ProposalFilterPreferencesUtil.getProposalFilterNames();
@ -41,10 +57,8 @@ public class ProposalFilterPreferencesTest extends TestCase {
assertTrue("Did not find expected filter!", index >= 0); assertTrue("Did not find expected filter!", index >= 0);
// Set the preference to the tested filter // Set the preference to the tested filter
IPreferenceStore store = CUIPlugin.getDefault().getPreferenceStore();
String filterComboStateString = store.getString(ContentAssistPreference.PROPOSALS_FILTER);
ProposalFilterPreferencesUtil.ComboState state = ProposalFilterPreferencesUtil ProposalFilterPreferencesUtil.ComboState state = ProposalFilterPreferencesUtil
.getComboState(filterComboStateString); .getComboState(filterComboStateStringBefore);
StringBuilder newStateText = new StringBuilder(); StringBuilder newStateText = new StringBuilder();
newStateText.append(index + 1); // First entry is always the <Default Filter>, index+1 must be selected newStateText.append(index + 1); // First entry is always the <Default Filter>, index+1 must be selected
for (int i = 0; i < state.items.length; i++) { for (int i = 0; i < state.items.length; i++) {