mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

Stop using _ identifier

Browse source 
From JLS 15.27.1.

It is a compile-time error if a lambda parameter has the name _ (that
is, a single underscore character).

The use of the variable name _ in any context is discouraged. Future
versions of the Java programming language may reserve this name as a
keyword and/or give it special semantics.

Change-Id: I6f357dcc8f1eea933c6fc3afb474982e6d6210fe
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
This commit is contained in:
Jonah Graham 2016-04-15 11:12:02 +01:00
parent 3c09a628a2
commit 1dd218df31
4 changed files with 35 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/CharArrayMapTest.java
View file

@ -288,85 +288,85 @@ public class CharArrayMapTest extends TestCase {
try { try {
map.put(null, value); map.put(null, value);
fail(); fail();
} catch(NullPointerException _) {} } catch(NullPointerException expectedException) {}
try { try {
map.put(hello, -1, 5, value); map.put(hello, -1, 5, value);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.put(hello, 0, -1, value); map.put(hello, 0, -1, value);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.put(hello, 0, 100, value); map.put(hello, 0, 100, value);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.get(null); map.get(null);
fail(); fail();
} catch(NullPointerException _) {} } catch(NullPointerException expectedException) {}
try { try {
map.get(hello, -1, 5); map.get(hello, -1, 5);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.get(hello, 0, -1); map.get(hello, 0, -1);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.get(hello, 0, 100); map.get(hello, 0, 100);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.remove(null); map.remove(null);
fail(); fail();
} catch(NullPointerException _) {} } catch(NullPointerException expectedException) {}
try { try {
map.remove(hello, -1, 5); map.remove(hello, -1, 5);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.remove(hello, 0, -1); map.remove(hello, 0, -1);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.remove(hello, 0, 100); map.remove(hello, 0, 100);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.containsKey(null); map.containsKey(null);
fail(); fail();
} catch(NullPointerException _) {} } catch(NullPointerException expectedException) {}
try { try {
map.containsKey(hello, -1, 5); map.containsKey(hello, -1, 5);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.containsKey(hello, 0, -1); map.containsKey(hello, 0, -1);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
map.containsKey(hello, 0, 100); map.containsKey(hello, 0, 100);
fail(); fail();
} catch(IndexOutOfBoundsException _) {} } catch(IndexOutOfBoundsException expectedException) {}
try { try {
new CharArrayMap<Integer>(-1); new CharArrayMap<Integer>(-1);
} catch(IllegalArgumentException _) {} } catch(IllegalArgumentException expectedException) {}
} }
} }

26
lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRCompleteParser2Tests.java
View file

@ -56,9 +56,9 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// public void testBug39676_tough() { // is this C99? // public void testBug39676_tough() { // is this C99?
// try { // try {
// super.testBug39676_tough(); // super.testBug39676_tough();
// } catch(AssertionFailedError _) { // } catch(AssertionFailedError expectedException) {
// return; // return;
// } catch(Exception _) { // } catch(Exception expectedException) {
// return; // return;
// } // }
// fail(); // fail();
@ -68,14 +68,14 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.testPredefinedSymbol_bug70928_infinite_loop_test1(); // super.testPredefinedSymbol_bug70928_infinite_loop_test1();
// fail(); // fail();
// } catch(AssertionError _) { } // } catch(AssertionError expectedException) { }
// } // }
// //
// public void testPredefinedSymbol_bug70928_infinite_loop_test2() throws Exception { // gcc extension // public void testPredefinedSymbol_bug70928_infinite_loop_test2() throws Exception { // gcc extension
// try { // try {
// super.testPredefinedSymbol_bug70928_infinite_loop_test2(); // super.testPredefinedSymbol_bug70928_infinite_loop_test2();
// fail(); // fail();
// } catch(AssertionError _) { } // } catch(AssertionError expectedException) { }
// } // }
@ -84,7 +84,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.testBug102376(); // super.testBug102376();
// fail(); // fail();
// } catch(AssertionFailedError _) { } // } catch(AssertionFailedError expectedException) { }
// } // }
// @Override // @Override
@ -92,7 +92,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.test158192_declspec_in_declarator(); // super.test158192_declspec_in_declarator();
// fail(); // fail();
// } catch(AssertionFailedError _) { } // } catch(AssertionFailedError expectedException) { }
// } // }
// //
// @Override // @Override
@ -100,7 +100,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.test158192_declspec_on_class(); // super.test158192_declspec_on_class();
// fail(); // fail();
// } catch(AssertionFailedError _) { } // } catch(AssertionFailedError expectedException) { }
// } // }
// //
// @Override // @Override
@ -108,7 +108,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.test158192_declspec_on_variable(); // super.test158192_declspec_on_variable();
// fail(); // fail();
// } catch(AssertionFailedError _) { } // } catch(AssertionFailedError expectedException) { }
// } // }
// //
// @Override // @Override
@ -116,7 +116,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.testPredefinedSymbol_bug70928(); // super.testPredefinedSymbol_bug70928();
// fail(); // fail();
// } catch(AssertionFailedError _) { } // } catch(AssertionFailedError expectedException) { }
// } // }
@Override @Override
@ -124,7 +124,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
try { try {
//super.testBug64010(); //super.testBug64010();
//fail(); //fail();
} catch(AssertionFailedError _) { } } catch(AssertionFailedError expectedException) { }
} }
// //
@ -133,8 +133,8 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.testGNUASMExtension(); // super.testGNUASMExtension();
// fail(); // fail();
// } catch(AssertionFailedError _) { // } catch(AssertionFailedError expectedException) {
// } catch(AssertionError _) { // } catch(AssertionError expectedException) {
// } // }
// } // }
// //
@ -143,7 +143,7 @@ public class LRCompleteParser2Tests extends CompleteParser2Tests {
// try { // try {
// super.testBug39551B(); // super.testBug39551B();
// fail(); // fail();
// } catch(AssertionFailedError _) { } // } catch(AssertionFailedError expectedException) { }
// } // }
// //
// //

8
lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRKnRTests.java
View file

@ -54,7 +54,7 @@ public class LRKnRTests extends AST2KnRTests {
try { try {
super.testKRCProblem3(); super.testKRCProblem3();
fail(); fail();
} catch(Throwable _) { } } catch(Throwable expectedException) { }
} }
@Override @Override
@ -62,7 +62,7 @@ public class LRKnRTests extends AST2KnRTests {
try { try {
super.testKRCProblem4(); super.testKRCProblem4();
fail(); fail();
} catch(Throwable _) { } } catch(Throwable expectedException) { }
} }
@Override @Override
@ -70,7 +70,7 @@ public class LRKnRTests extends AST2KnRTests {
try { try {
super.testKRCProblem5(); super.testKRCProblem5();
fail(); fail();
} catch(Throwable _) { } } catch(Throwable expectedException) { }
} }
@Override @Override
@ -78,7 +78,7 @@ public class LRKnRTests extends AST2KnRTests {
try { try {
super.testKRCProblem2(); super.testKRCProblem2();
fail(); fail();
} catch(Throwable _) { } } catch(Throwable expectedException) { }
} }
} }

2
lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRUtilOldTests.java
View file

@ -51,6 +51,6 @@ public class LRUtilOldTests extends AST2UtilOldTests {
try { try {
super.testCastExpression(); super.testCastExpression();
fail(); fail();
} catch(AssertionFailedError _) {} } catch(AssertionFailedError expectedException) {}
} }
} }