From 1db10b1da91322b8e27d0773d353bc61184b953c Mon Sep 17 00:00:00 2001 From: Ted Williams Date: Fri, 5 Oct 2007 19:41:49 +0000 Subject: [PATCH] [205606] Edits should be colorized even if the value has not been changed; embedded users want to see that the memory will be written. --- .../dd/debug/memory/renderings/traditional/DataPane.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/traditional/DataPane.java b/plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/traditional/DataPane.java index bc3e0630c0c..b46b48a41e4 100644 --- a/plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/traditional/DataPane.java +++ b/plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/traditional/DataPane.java @@ -93,11 +93,14 @@ public class DataPane extends AbstractPane bytesToSet[i] = new TraditionalMemoryByte(byteData[i]); bytesToSet[i].setBigEndian(bytes[i].isBigEndian()); - if(bytes[i].getValue() != byteData[i]) + // for embedded, the user wants feedback that the change will be sent to the target, + // even if does not change the value. eventually, maybe we need another color to + // indicate change. + //if(bytes[i].getValue() != byteData[i]) { bytesToSet[i].setEdited(true); } - else + //else { if(bytes[i] instanceof TraditionalMemoryByte) bytesToSet[i].setEdited(((TraditionalMemoryByte) bytes[i]).isEdited());