From 1a0c51205ed3a936b31b6cdc464a46ba28167ae4 Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Fri, 11 Mar 2016 15:54:23 -0500 Subject: [PATCH] Bug 488904 - Performance regression of code completion due to parameter guessing Code cleanup. Change-Id: Idf8fadddef683bd1161a0d60333e47cd2437d730 --- .../contentassist/DOMCompletionProposalComputer.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java index 2936d79b89f..1b907199e98 100644 --- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java +++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java @@ -703,7 +703,7 @@ public class DOMCompletionProposalComputer extends ParsingBasedProposalComputer // Get all variables declared in the translation unit. final Set declaredVariables = new HashSet<>(); - ast.accept(new NameVisitor() { + ast.accept(new ASTVisitor(true) { @Override public int visit(IASTName name) { if (getNodeOffset(name) >= statementOffset) @@ -715,7 +715,7 @@ public class DOMCompletionProposalComputer extends ParsingBasedProposalComputer declaredVariables.add(binding); } } - return PROCESS_CONTINUE; + return PROCESS_SKIP; // Do non visit internals of qualified names. } }); @@ -954,10 +954,4 @@ public class DOMCompletionProposalComputer extends ParsingBasedProposalComputer private static IPreferenceStore getPreferenceStore() { return CUIPlugin.getDefault().getPreferenceStore(); } - - private static abstract class NameVisitor extends ASTVisitor { - NameVisitor() { - shouldVisitNames = true; - } - } }