From 19db5c51b8cb3e5ff8822526599470e8d13f8907 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Mon, 22 Sep 2008 19:43:11 +0000 Subject: [PATCH] [239050] The method debugNewProcess() should actually return an IContainerDMContext with the IProcessDMContext as its parent, since the debugger is attached to the process. We had agreed to keep IRunControl contexts out of IProcesses, so this patch simply allows debugNewProcess() to return any context (IDMContext.) --- .../src/org/eclipse/dd/dsf/debug/service/IProcesses.java | 5 +++-- .../gdb/internal/provisional/service/GDBProcesses_7_0.java | 2 +- .../src/org/eclipse/dd/mi/service/MIProcesses.java | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IProcesses.java b/plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IProcesses.java index eec93d09dd1..26d3aef3c11 100644 --- a/plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IProcesses.java +++ b/plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/IProcesses.java @@ -138,9 +138,10 @@ public interface IProcesses extends IDMService { /** * Starts a new process with the debugger attached. * @param file Process image to use for the new process. - * @param rm Request completion monitor, to be willed in with the process context. + * @param rm Request completion monitor, to be filled in with the + * debugging context that can now be used to characterize the process */ - void debugNewProcess(String file, DataRequestMonitor rm); + void debugNewProcess(String file, DataRequestMonitor rm); /** * Retrieves the list of processes which are currently under debugger control. diff --git a/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/service/GDBProcesses_7_0.java b/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/service/GDBProcesses_7_0.java index 524e5b002a4..188981b50d2 100644 --- a/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/service/GDBProcesses_7_0.java +++ b/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/service/GDBProcesses_7_0.java @@ -549,7 +549,7 @@ public class GDBProcesses_7_0 extends AbstractDsfService implements IMIProcesses rm.done(); } - public void debugNewProcess(String file, DataRequestMonitor rm) { + public void debugNewProcess(String file, DataRequestMonitor rm) { rm.setStatus(new Status(IStatus.ERROR, GdbPlugin.PLUGIN_ID, NOT_SUPPORTED, "Not supported", null)); //$NON-NLS-1$ rm.done(); diff --git a/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIProcesses.java b/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIProcesses.java index 45fc60f3a34..d9a14975a00 100644 --- a/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIProcesses.java +++ b/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIProcesses.java @@ -534,7 +534,7 @@ public class MIProcesses extends AbstractDsfService implements IMIProcesses, ICa rm.done(); } - public void debugNewProcess(String file, DataRequestMonitor rm) { + public void debugNewProcess(String file, DataRequestMonitor rm) { rm.setStatus(new Status(IStatus.ERROR, MIPlugin.PLUGIN_ID, NOT_SUPPORTED, "Not supported", null)); //$NON-NLS-1$ rm.done();