mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 231655

Browse source 
Race condition for invalid expressions
This commit is contained in:
Marc Khouzam 2008-05-14 20:03:00 +00:00
parent d773c86420
commit 193f47ef69
1 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIVariableManager.java
View file

@ -988,17 +988,11 @@ public class MIVariableManager implements ICommandControl {
if (isModifiable()) {
addModifiableDescendant(getData().getName(), MIRootVariableObject.this);
}
rm.done();
// Object can now be used by others
creationCompleted(true);
} else {
rm.setStatus(getStatus());
rm.done();
// Object must tell any waiting monitors that it failed
creationCompleted(false);
}
rm.done();
}
});
} else {
@ -1451,12 +1445,26 @@ public class MIVariableManager implements ICommandControl {
if (isSuccess()) {
// Also store the object as a varObj that is up-to-date
updatedRootList.add(newVarObj);
// VarObj can now be used by others
newVarObj.creationCompleted(true);
rm.setData(newVarObj);
rm.done();
} else {
// Object was not created, remove it from our list
lruVariableList.remove(id);
// Tell any waiting monitors that creation failed.
// It is important to do this call after we have removed the id
// from our LRU; this is to avoid the following:
// The same varObj is requested before it was removed from the LRU
// but after we called creationCompleted().
// In this case, the request for this varObj would be queued, but
// since creationCompleted() already sent the notifications
// the newly queue request will never get serviced.
// We avoid this race condition by sending the notifications _after_ removing
// the object from the LRU, to avoid any new requests being queue.
// See https://bugs.eclipse.org/bugs/show_bug.cgi?id=231655
newVarObj.creationCompleted(false);
rm.setStatus(getStatus());
rm.done();