mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-01 14:15:23 +02:00
Code Issues Wiki Activity

Bug 520846 - Use ArrayContentProvider.getInstance() where possible

Browse source 
As ArrayContentProvider is stateless, re-using the global instance
avoids a few allocations.

Change-Id: Ia378195c2c90e35badcf6e2c1938a93877a442e6
Signed-off-by: Andreas Sewe <andreas.sewe@codetrails.com>
This commit is contained in:
Andreas Sewe 2017-08-10 15:51:19 +02:00 • committed by Doug Schaefer
parent 35135aa605
commit 18831f4407
7 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/filters/CustomFiltersDialog.java
View file

@ -177,7 +177,7 @@ public class CustomFiltersDialog extends SelectionDialog {
fCheckBoxList.getTable().setLayoutData(data);
fCheckBoxList.setLabelProvider(createLabelPrivder());
fCheckBoxList.setContentProvider(new ArrayContentProvider());
fCheckBoxList.setContentProvider(ArrayContentProvider.getInstance());
fCheckBoxList.setInput(fBuiltInFilters);
setInitialSelections(getEnabledFilterDescriptors());

2
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/language/settings/providers/LanguageSettingsProviderTab.java
View file

@ -426,7 +426,7 @@ public class LanguageSettingsProviderTab extends AbstractCPropertyTab {
}
});
tableProvidersViewer = new CheckboxTableViewer(tableProviders);
tableProvidersViewer.setContentProvider(new ArrayContentProvider());
tableProvidersViewer.setContentProvider(ArrayContentProvider.getInstance());
tableProvidersViewer.setLabelProvider(new ProvidersTableLabelProvider());
tableProvidersViewer.addCheckStateListener(new ICheckStateListener() {

4
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/preferences/CodeAssistAdvancedConfigurationBlock.java
View file

@ -454,7 +454,7 @@ final class CodeAssistAdvancedConfigurationBlock extends OptionsConfigurationBlo
}
});
fDefaultViewer.setContentProvider(new ArrayContentProvider());
fDefaultViewer.setContentProvider(ArrayContentProvider.getInstance());
DefaultTableLabelProvider labelProvider= new DefaultTableLabelProvider();
fDefaultViewer.setLabelProvider(labelProvider);
@ -526,7 +526,7 @@ final class CodeAssistAdvancedConfigurationBlock extends OptionsConfigurationBlo
nameColumn.setText(PreferencesMessages.CodeAssistAdvancedConfigurationBlock_separate_table_category_column_title);
nameColumn.setResizable(false);
fSeparateViewer.setContentProvider(new ArrayContentProvider());
fSeparateViewer.setContentProvider(ArrayContentProvider.getInstance());
ITableLabelProvider labelProvider= new SeparateTableLabelProvider();
fSeparateViewer.setLabelProvider(labelProvider);

2
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/preferences/formatter/WhiteSpaceTabPage.java
View file

@ -264,7 +264,7 @@ public class WhiteSpaceTabPage extends FormatterTabPage {
fInnerViewer.getControl().setLayoutData(innerGd);
fOptionsViewer= CheckboxTableViewer.newCheckList(sashForm, SWT.SINGLE | SWT.BORDER | SWT.H_SCROLL);
fOptionsViewer.setContentProvider(new ArrayContentProvider());
fOptionsViewer.setContentProvider(ArrayContentProvider.getInstance());
fOptionsViewer.setLabelProvider(new LabelProvider());
final GridData optionsGd= createGridData(numColumns, GridData.HORIZONTAL_ALIGN_FILL | GridData.FILL_VERTICAL, SWT.DEFAULT);

2
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/RefactoringSaveHelper.java
View file

@ -204,7 +204,7 @@ public class RefactoringSaveHelper {
dialog.setTitle(Messages.RefactoringSaveHelper_save_all_resources);
dialog.setLabelProvider(createDialogLabelProvider());
dialog.setMessage(Messages.RefactoringSaveHelper_must_save);
dialog.setContentProvider(new ArrayContentProvider());
dialog.setContentProvider(ArrayContentProvider.getInstance());
dialog.setInput(Arrays.asList(dirtyEditors));
return dialog.open() == Window.OK;
}

2
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/dialogs/RegexErrorParserOptionPage.java
View file

@ -332,7 +332,7 @@ public final class RegexErrorParserOptionPage extends AbstractCOptionPage {
fTableViewer = new TableViewer(fTable);
fTableViewer.setUseHashlookup(true);
fTableViewer.setContentProvider(new ArrayContentProvider());
fTableViewer.setContentProvider(ArrayContentProvider.getInstance());
//Bug 307542 - [Accessibility] Error Parser Options table should be accessible by keyboard
TableViewerFocusCellManager focusCellManager = new TableViewerFocusCellManager(fTableViewer,new FocusCellOwnerDrawHighlighter(fTableViewer));

2
debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/sourcelookup/AddSourceContainerDialog.java
View file

@ -94,7 +94,7 @@ public class AddSourceContainerDialog extends TitleAreaDialog {
}
fViewer.setLabelProvider(new SourceContainerLabelProvider());
fViewer.setContentProvider(new ArrayContentProvider());
fViewer.setContentProvider(ArrayContentProvider.getInstance());
fViewer.setSorter(new ViewerSorter());
fViewer.addSelectionChangedListener(new ISelectionChangedListener() {
@Override