mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-09-10 03:53:21 +02:00
Code Issues Wiki Activity

Bug 573677: Mark methods that don't handle commands well as deprecated

Browse source 
Some of these commands work "by accident" on Windows, but there are lots
of special/corner cases that may not. On Linux they almost certainly
never do the correct thing when spaces are in arguments.

Change-Id: Idce714da9c1d6ac7a67dc174d5b30bf619534c53
This commit is contained in:
Jonah Graham 2021-05-23 00:14:38 -04:00
parent a4963b35ad
commit 1557c2c4f5
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/spawner/Spawner.java
View file

@ -72,6 +72,10 @@ public class Spawner extends Process {
InputStream err; InputStream err;
private PTY fPty; private PTY fPty;
/**
* @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
public Spawner(String command, boolean bNoRedirect) throws IOException { public Spawner(String command, boolean bNoRedirect) throws IOException {
StringTokenizer tokenizer = new StringTokenizer(command); StringTokenizer tokenizer = new StringTokenizer(command);
String[] cmdarray = new String[tokenizer.countTokens()]; String[] cmdarray = new String[tokenizer.countTokens()];
@ -104,7 +108,9 @@ public class Spawner extends Process {
/** /**
* Executes the specified string command in a separate process. * Executes the specified string command in a separate process.
**/ * @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
protected Spawner(String command) throws IOException { protected Spawner(String command) throws IOException {
this(command, null); this(command, null);
} }
@ -127,7 +133,9 @@ public class Spawner extends Process {
/** /**
* Executes the specified string command in a separate process with the specified * Executes the specified string command in a separate process with the specified
* environment. * environment.
**/ * @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
protected Spawner(String cmd, String[] envp) throws IOException { protected Spawner(String cmd, String[] envp) throws IOException {
this(cmd, envp, null); this(cmd, envp, null);
} }
@ -135,7 +143,9 @@ public class Spawner extends Process {
/** /**
* Executes the specified string command in a separate process with the specified * Executes the specified string command in a separate process with the specified
* environment and working directory. * environment and working directory.
**/ * @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
protected Spawner(String command, String[] envp, File dir) throws IOException { protected Spawner(String command, String[] envp, File dir) throws IOException {
StringTokenizer tokenizer = new StringTokenizer(command); StringTokenizer tokenizer = new StringTokenizer(command);
String[] cmdarray = new String[tokenizer.countTokens()]; String[] cmdarray = new String[tokenizer.countTokens()];