From 1548edd7e57470d841cb37f6b8f99397adedb063 Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Sat, 11 Feb 2012 16:53:32 -0800 Subject: [PATCH] Cosmetics. --- .../checkers/ClassMembersInitializationCheckerTest.java | 2 -- .../src/org/eclipse/cdt/codan/core/test/TestUtils.java | 2 +- .../codan/internal/core/model/CodanMarkerProblemReporter.java | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/ClassMembersInitializationCheckerTest.java b/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/ClassMembersInitializationCheckerTest.java index c640ec645f7..9ae480af840 100644 --- a/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/ClassMembersInitializationCheckerTest.java +++ b/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/ClassMembersInitializationCheckerTest.java @@ -15,7 +15,6 @@ import org.eclipse.cdt.codan.internal.checkers.ClassMembersInitializationChecker /** * Test for {@see ClassMembersInitializationChecker} class - * */ public class ClassMembersInitializationCheckerTest extends CheckerTestCase { @Override @@ -476,5 +475,4 @@ public class ClassMembersInitializationCheckerTest extends CheckerTestCase { loadCodeAndRun(getAboveComment()); checkErrorLines(8,9,10,11); } - } diff --git a/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/test/TestUtils.java b/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/test/TestUtils.java index 020c60bb21f..6417d4f6cb9 100644 --- a/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/test/TestUtils.java +++ b/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/test/TestUtils.java @@ -41,7 +41,7 @@ public class TestUtils { public static String loadFile(InputStream st) throws IOException { BufferedReader br = new BufferedReader(new InputStreamReader(st)); String buffer; - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); while ((buffer = br.readLine()) != null) { result.append(buffer); } diff --git a/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanMarkerProblemReporter.java b/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanMarkerProblemReporter.java index 4a7cc5f81c1..331aa5d46d1 100644 --- a/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanMarkerProblemReporter.java +++ b/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanMarkerProblemReporter.java @@ -140,8 +140,7 @@ public class CodanMarkerProblemReporter extends AbstractProblemReporter } ICheckersRegistry reg = CodanRuntime.getInstance().getCheckersRegistry(); Collection problems = reg.getRefProblems(checker); - for (int i = 0; i < markers.length; i++) { - IMarker m = markers[i]; + for (IMarker m : markers) { String id = m.getAttribute(ICodanProblemMarker.ID, ""); //$NON-NLS-1$ for (IProblem problem : problems) { if (problem.getId().equals(id)) {