mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-04 14:55:41 +02:00
Code Issues Wiki Activity

[413178] UniversalFileTransferUtility isn't setting read-only bit if

Browse source 
encoding and timestamp are unchanged
This commit is contained in:
David McKnight 2013-07-17 11:55:51 -04:00
parent 53f07d052c
commit 14ade17e04
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/resources/UniversalFileTransferUtility.java
View file

@ -66,6 +66,7 @@
* David McKnight (IBM) - [386486] when the original timestamp of a file is 0 don't set it after an upload * David McKnight (IBM) - [386486] when the original timestamp of a file is 0 don't set it after an upload
* David McKnight (IBM) - [389838] Fast folder transfer does not account for code page * David McKnight (IBM) - [389838] Fast folder transfer does not account for code page
* Samuel Wu (IBM) - [402533] UniversalFileTransferUtility threw NPE * Samuel Wu (IBM) - [402533] UniversalFileTransferUtility threw NPE
* David McKnight (IBM) - [413178] UniversalFileTransferUtility isn't setting read-only bit if encoding and timestamp are unchanged
*******************************************************************************/ *******************************************************************************/
package org.eclipse.rse.files.ui.resources; package org.eclipse.rse.files.ui.resources;
@ -721,16 +722,15 @@ public class UniversalFileTransferUtility {
String storedEncoding = properties.getEncoding(); String storedEncoding = properties.getEncoding();
String currentEncoding = srcFileOrFolder.getEncoding(); String currentEncoding = srcFileOrFolder.getEncoding();
if (storedTime != currentTime || (storedEncoding == null || !storedEncoding.equals(currentEncoding)))
{
if (tempFile.exists()) if (tempFile.exists())
{ {
// deal with encoding properties
if (storedEncoding == null || !storedEncoding.equals(currentEncoding)){
// set the appropriate readonly flag // set the appropriate readonly flag
boolean readOnly = !srcFileOrFolder.canWrite(); boolean readOnly = !srcFileOrFolder.canWrite();
setReadOnly(tempFile, readOnly); setReadOnly(tempFile, readOnly);
if (storedTime != currentTime || (storedEncoding == null || !storedEncoding.equals(currentEncoding)))
{
// deal with encoding properties
if (storedEncoding == null || !storedEncoding.equals(currentEncoding)){
try try
{ {
if (remoteEncoding != null) if (remoteEncoding != null)