From 139fe3da96b0c1eeac3599cc7acb7c49b7290822 Mon Sep 17 00:00:00 2001
From: ewaterlander <102143930+ewaterlander@users.noreply.github.com>
Date: Sun, 15 Dec 2024 22:26:10 +0100
Subject: [PATCH] Common tab for Core Build local launch configuration. (#970)

Added the Common tab. For instance handy for redirecting program
output to a file.
---
 dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml | 12 ++++++++++++
 launch/org.eclipse.cdt.launch/plugin.xml      | 12 ++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml
index b22826315ba..8fb238ec9e9 100644
--- a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml
+++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml
@@ -219,6 +219,18 @@
                after="org.eclipse.cdt.dsf.gdb.launch.debuggerTab">
          </placement>
       </tab>
+      <tab
+            class="org.eclipse.debug.ui.CommonTab"
+            group="org.eclipse.cdt.launch.launchConfigurationTabGroup.local"
+            id="org.eclipse.cdt.cdi.launch.localCoreBuild.commonTab"
+            name="%launchTab.common.name">
+         <associatedDelegate
+               delegate="org.eclipse.cdt.dsf.gdb.coreBuildLocalDebug">
+         </associatedDelegate>
+         <placement
+               after="org.eclipse.debug.ui.sourceLookupTab">
+         </placement>
+      </tab>
    </extension>
    <extension point="org.eclipse.core.runtime.adapters">
       <!-- Extenders providing their own subclass of GdbAdapterFactory must also extend GdbLaunch 
diff --git a/launch/org.eclipse.cdt.launch/plugin.xml b/launch/org.eclipse.cdt.launch/plugin.xml
index c3f298f9905..3a656d229fb 100644
--- a/launch/org.eclipse.cdt.launch/plugin.xml
+++ b/launch/org.eclipse.cdt.launch/plugin.xml
@@ -108,6 +108,18 @@
                after="org.eclipse.cdt.cdi.launch.argumentsTab">
          </placement>
       </tab>
+      <tab
+            class="org.eclipse.debug.ui.CommonTab"
+            group="org.eclipse.cdt.launch.launchRunConfigurationTabGroup.local"
+            id="org.eclipse.cdt.cdi.launch.runLocalCoreBuild.commonTab"
+            name="%CommonLaunchTab.name">
+         <associatedDelegate
+               delegate="org.eclipse.cdt.cdi.launch.localCoreBuildCLaunch">
+         </associatedDelegate>
+         <placement
+               after="org.eclipse.debug.ui.environmentTab">
+         </placement>
+      </tab>
    </extension>
    <extension
          point="org.eclipse.debug.core.statusHandlers">