From 1353648effa0c07ec3703d3f06b77cd378a3ee82 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Mon, 5 Oct 2009 18:00:54 +0000 Subject: [PATCH] [291393] Memory leak in RequestMonitor --- .../src/org/eclipse/cdt/dsf/concurrent/RequestMonitor.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/concurrent/RequestMonitor.java b/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/concurrent/RequestMonitor.java index 5105d344319..0f3171a7dc5 100644 --- a/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/concurrent/RequestMonitor.java +++ b/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/concurrent/RequestMonitor.java @@ -252,6 +252,13 @@ public class RequestMonitor extends DsfExecutable { throw new IllegalStateException("RequestMonitor: " + this + ", done() method called more than once"); //$NON-NLS-1$//$NON-NLS-2$ } fDone = true; + + // This RequestMonitor is done, it can no longer be canceled. + // We must clear the list of cancelListeners because it causes a + // circular reference between parent and child requestMonitor, which + // causes a memory leak. + fCancelListeners = null; + try { fExecutor.execute(new DsfRunnable() { public void run() {