mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

[159683] Added a few comments and fixed a couple of warnings while reviewing changes.

Browse source
This commit is contained in:
Pawel Piech 2007-09-07 15:42:51 +00:00
parent a89a6117aa
commit 0f827f7b2b
1 changed files with 85 additions and 70 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

155
plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/update/VMCache.java
View file

@ -48,9 +48,9 @@ public abstract class VMCache
protected HashMap<IDMContext<?>, IDMData> fDataArchive = fData; protected HashMap<IDMContext<?>, IDMData> fDataArchive = fData;
public HashMap[] getCacheData() public HashMap<?,?>[] getCacheData()
{ {
return new HashMap[] { fHasChildren, fChildrenCounts, fChildren, fData, fDataArchive }; return new HashMap<?,?>[] { fHasChildren, fChildrenCounts, fChildren, fData, fDataArchive };
} }
public VMCache() public VMCache()
@ -58,17 +58,19 @@ public abstract class VMCache
} }
public VMCache(VMCache oldCache) // Suppress warnings related to the lost type information in getCacheData()
@SuppressWarnings("unchecked")
public VMCache(VMCache oldCache)
{ {
if(oldCache != null) if(oldCache != null)
{ {
HashMap oldCacheData[] = oldCache.getCacheData(); HashMap<?,?> oldCacheData[] = oldCache.getCacheData();
fHasChildren = oldCacheData[0]; fHasChildren = (HashMap<Object, Boolean>)oldCacheData[0];
fChildrenCounts = oldCacheData[1]; fChildrenCounts = (HashMap<Object, Integer>)oldCacheData[1];
fChildren = oldCacheData[2]; fChildren = (HashMap<Object, HashMap<Integer,Object>>)oldCacheData[2];
fData = oldCacheData[3]; fData = (HashMap<IDMContext<?>, IDMData>)oldCacheData[3];
fDataArchive = oldCacheData[4]; fDataArchive = (HashMap<IDMContext<?>, IDMData>)oldCacheData[4];
} }
} }
@ -81,12 +83,23 @@ public abstract class VMCache
fChildren.clear(); fChildren.clear();
fHasChildren.clear(); fHasChildren.clear();
} }
/**
* Returns whether the data in this cache should used when servicing
* view updates. If this method returns false all updates will be
* sent to the view model, although the retrieved data should still
* be stored in the cache if {@link #isCacheWriteEnabled()} returns true.
* @return
*/
protected boolean isCacheReadEnabled() protected boolean isCacheReadEnabled()
{ {
return true; return true;
} }
/**
* Returns true if data retrieved from the view model should be cached.
* If this returns false, then the state of the cache is frozen.
*/
protected boolean isCacheWriteEnabled() protected boolean isCacheWriteEnabled()
{ {
return true; return true;
@ -266,66 +279,68 @@ public abstract class VMCache
for(int i = 0; i < updates.length; i++) for(int i = 0; i < updates.length; i++)
{ {
final IChildrenUpdate update = updatesEntirelyMissingFromCache.elementAt(i); final IChildrenUpdate update = updatesEntirelyMissingFromCache.elementAt(i);
updates[i] = new VMElementsUpdate(update, update.getOffset(), update.getLength(), updates[i] =
new DataRequestMonitor<List<Object>>(fExecutor, null) new VMElementsUpdate(
{ update, update.getOffset(), update.getLength(),
@Override new DataRequestMonitor<List<Object>>(fExecutor, null)
protected void handleCompleted() {
{ @Override
if(getData() != null) protected void handleCompleted()
{ {
for(int j = 0; j < getData().size(); j++) if(getData() != null)
{ {
if(isCacheWriteEnabled()) for(int j = 0; j < getData().size(); j++)
{ {
if(!fChildren.containsKey(update.getElement())) if(isCacheWriteEnabled())
fChildren.put(update.getElement(), new HashMap<Integer,Object>()); {
if(!fChildren.containsKey(update.getElement()))
fChildren.get(update.getElement()).put(update.getOffset() + j, getData().get(j)); fChildren.put(update.getElement(), new HashMap<Integer,Object>());
}
fChildren.get(update.getElement()).put(update.getOffset() + j, getData().get(j));
update.setChild(getData().get(j), update.getOffset() + j); }
}
} update.setChild(getData().get(j), update.getOffset() + j);
update.done(); }
} }
}) update.done();
{ }
/* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=202109 })
* {
* A flexible hierarchy bug/optimization causes query with incorrect /* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=202109
* IChildrenUpdate[] array length. *
* * A flexible hierarchy bug/optimization causes query with incorrect
* We found this while deleting a register node. Example: * IChildrenUpdate[] array length.
* *
* the register view displays: * We found this while deleting a register node. Example:
* PC *
* EAX * the register view displays:
* EBX * PC
* ECX * EAX
* EDX * EBX
* * ECX
* we delete EBX and force a context refresh. * EDX
* *
* flexible hierarchy queries for IChildrenUpdate[5] and IChildrenCountUpdate at * we delete EBX and force a context refresh.
* the same time. *
* * flexible hierarchy queries for IChildrenUpdate[5] and IChildrenCountUpdate at
* VMElementsUpdate, used by VMCache to wrap the IChildrenUpdate, generates an * the same time.
* IStatus.ERROR with message "Incomplete elements of updates" when fElements *
* count (provided by service) does not match the length provided by the original * VMElementsUpdate, used by VMCache to wrap the IChildrenUpdate, generates an
* update query. * IStatus.ERROR with message "Incomplete elements of updates" when fElements
* * count (provided by service) does not match the length provided by the original
* Workaround, respect getData() != null instead of IStatus.OK, override * update query.
* VMElementsUpdate.done() to set elements regardless of count *
*/ * Workaround, respect getData() != null instead of IStatus.OK, override
@Override * VMElementsUpdate.done() to set elements regardless of count
public void done() { */
@SuppressWarnings("unchecked") @Override
DataRequestMonitor<List<Object>> rm = (DataRequestMonitor<List<Object>>)fRequestMonitor; public void done() {
rm.setData(fElements); @SuppressWarnings("unchecked")
super.done(); DataRequestMonitor<List<Object>> rm = (DataRequestMonitor<List<Object>>)fRequestMonitor;
} rm.setData(fElements);
}; super.done();
}
};
} }
return updates; return updates;