From 0d4fcccd3d9c2fdedb47202bd7b50f8a01fa7b3d Mon Sep 17 00:00:00 2001
From: Jonah Graham <jonah@kichwacoders.com>
Date: Fri, 29 Nov 2019 12:10:02 -0500
Subject: [PATCH] Bug 553613: Limit memory growth on generated typenames

When using the cache, only put the string reference in the typename
if over the threshold.

This is essentially a fixup for Bug 519121

Change-Id: I1436a9740bfb8ce46747f9a2ab0649ed366c4d9b
---
 .../parser/org/eclipse/cdt/core/dom/ast/ASTTypeUtil.java       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/ASTTypeUtil.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/ASTTypeUtil.java
index 0ea597d0485..60dab642d73 100644
--- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/ASTTypeUtil.java
+++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/ASTTypeUtil.java
@@ -649,8 +649,9 @@ public class ASTTypeUtil {
 				// requirement of appendStringReference().
 				if (cachedResult.length() > TYPE_STRING_LENGTH_THRESHOLD) {
 					appendStringReference(cachedResult, result);
+				} else {
+					result.append(cachedResult);
 				}
-				result.append(cachedResult);
 				return;
 			}
 		}