mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-03-28 14:56:28 +01:00
Code Issues Wiki Activity

Bug 539641 - [lldb] Pending breakpoints do not work

Browse source 
lldb-mi doesn't implement "-gdb-set breakpoint pending"
so instead we always use "-break-insert -f" to always use pending breakpoints.
Once the -gdb-set is implemented in lldb-mi, we can remove this.
See also https://reviews.llvm.org/D52953

Change-Id: Id07da58e0530898401d2f7285c44c97b38637542
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
This commit is contained in:
Marc-Andre Laperle 2018-10-06 00:16:51 -04:00
parent 8d8324ae14
commit 0cb3188339
1 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
llvm/org.eclipse.cdt.llvm.dsf.lldb.core/src/org/eclipse/cdt/llvm/dsf/lldb/core/internal/service/commands/LLDBCommandFactory.java
View file

@ -8,9 +8,12 @@
package org.eclipse.cdt.llvm.dsf.lldb.core.internal.service.commands;
import org.eclipse.cdt.dsf.debug.service.IBreakpoints.IBreakpointsTargetDMContext;
import org.eclipse.cdt.dsf.debug.service.command.ICommand;
import org.eclipse.cdt.dsf.mi.service.IMIContainerDMContext;
import org.eclipse.cdt.dsf.mi.service.command.CommandFactory;
import org.eclipse.cdt.dsf.mi.service.command.commands.MIBreakInsert;
import org.eclipse.cdt.dsf.mi.service.command.output.MIBreakInsertInfo;
import org.eclipse.cdt.dsf.mi.service.command.output.MIInfo;
/**
@ -36,4 +39,34 @@ public class LLDBCommandFactory extends CommandFactory {
public ICommand<MIInfo> createMIGDBSetArgs(IMIContainerDMContext dmc, String[] arguments) {
return super.createMIExecArguments(dmc, arguments);
}
/**
* lldb-mi (as of 8.0.0-r343825) doesn't implement "-gdb-set breakpoint pending"
* so instead we always use "-break-insert -f" to always use pending breakpoints.
* Once the -gdb-set is implemented in lldb-mi, we can remove this.
* See also https://reviews.llvm.org/D52953
*/
@Override
public ICommand<MIBreakInsertInfo> createMIBreakInsert(IBreakpointsTargetDMContext ctx, boolean isTemporary,
boolean isHardware, String condition, int ignoreCount, String line, String tid) {
return new MIBreakInsert(ctx, isTemporary, isHardware, condition, ignoreCount, line, tid, true);
}
/**
* @see #createMIBreakInsert(IBreakpointsTargetDMContext, boolean, boolean, String, int, String, String)
*/
@Override
public ICommand<MIBreakInsertInfo> createMIBreakInsert(IBreakpointsTargetDMContext ctx, boolean isTemporary,
boolean isHardware, String condition, int ignoreCount, String location, String tid, boolean disabled,
boolean isTracepoint) {
return new MIBreakInsert(ctx, isTemporary, isHardware, condition, ignoreCount, location, tid, disabled, isTracepoint, true);
}
/**
* @see #createMIBreakInsert(IBreakpointsTargetDMContext, boolean, boolean, String, int, String, String)
*/
@Override
public ICommand<MIBreakInsertInfo> createMIBreakInsert(IBreakpointsTargetDMContext ctx, String func) {
return new MIBreakInsert(ctx, func, true);
}
}