mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-05 23:35:48 +02:00
Code Issues Wiki Activity

[cleanup] fix 'local variable/field is never read' compiler warnings

Browse source
This commit is contained in:
Martin Oberhuber 2006-08-29 12:47:27 +00:00
parent 4fba9e5e29
commit 0b88e8bbc4
3 changed files with 17 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemView.java
View file

@ -796,7 +796,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
/** /**
* Helper method to collapse a node in the tree. * Helper method to collapse a node in the tree.
* Called when a currently expanded subsystem is disconnected. * Called when a currently expanded subsystem is disconnected.
* @param true if children should be deleted from memory so re-expand forces refresh. * @param forceRefresh true if children should be deleted from memory so re-expand forces refresh.
*/ */
public void collapseNode(Object element, boolean forceRefresh) public void collapseNode(Object element, boolean forceRefresh)
{ {
@ -1908,7 +1908,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
parentItem = findItem(parent); parentItem = findItem(parent);
if (parentItem == null) if (parentItem == null)
return Status.OK_STATUS; return Status.OK_STATUS;
if (multiSource.length > 0 && parentItem != null && parentItem instanceof Item ) if (multiSource.length > 0 && parentItem instanceof Item )
{ {
getControl().setRedraw(false); getControl().setRedraw(false);
collapseNode(parent, true); // collapse and flush gui widgets from memory collapseNode(parent, true); // collapse and flush gui widgets from memory
@ -2783,7 +2783,6 @@ public class SystemView extends TreeViewer implements ISystemTree,
else if (inputObj instanceof ISystemFilter) else if (inputObj instanceof ISystemFilter)
{ {
ISystemFilter filter = (ISystemFilter)inputObj; ISystemFilter filter = (ISystemFilter)inputObj;
if (filter == null) return null;
if (filter.getParentFilter() != null) if (filter.getParentFilter() != null)
return filter.getParentFilter(); return filter.getParentFilter();
else else
@ -3319,7 +3318,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* in order to uniquely find it. If not given this, we expand the first occurrence we find! * in order to uniquely find it. If not given this, we expand the first occurrence we find!
* @param remoteObject - either a remote object or a remote object absolute name * @param remoteObject - either a remote object or a remote object absolute name
* @param subsystem - the subsystem that owns the remote objects, to optimize searches. * @param subsystem - the subsystem that owns the remote objects, to optimize searches.
* @param parentobject - the parent that owns the remote objects, to optimize searches. Can * @param parentObject - the parent that owns the remote objects, to optimize searches. Can
* be an object or the absolute name of a remote object. * be an object or the absolute name of a remote object.
* @return the tree item of the remote object if found and expanded, else null * @return the tree item of the remote object if found and expanded, else null
*/ */
@ -3361,7 +3360,6 @@ public class SystemView extends TreeViewer implements ISystemTree,
} }
else // not given a parent to refine search with. Better have a subsystem!! else // not given a parent to refine search with. Better have a subsystem!!
{ {
remoteItem = null;
if (remoteObject instanceof String) if (remoteObject instanceof String)
remoteItem = findFirstRemoteItemReference((String)remoteObject, subsystem, (Item)null); remoteItem = findFirstRemoteItemReference((String)remoteObject, subsystem, (Item)null);
else else
@ -3385,7 +3383,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* Select a remote object or objects given the parent remote object (can be null) and subsystem (can be null) * Select a remote object or objects given the parent remote object (can be null) and subsystem (can be null)
* @param src - either a remote object, a remote object absolute name, or a vector of remote objects or remote object absolute names * @param src - either a remote object, a remote object absolute name, or a vector of remote objects or remote object absolute names
* @param subsystem - the subsystem that owns the remote objects, to optimize searches. * @param subsystem - the subsystem that owns the remote objects, to optimize searches.
* @param parentobject - the parent that owns the remote objects, to optimize searches. * @param parentObject - the parent that owns the remote objects, to optimize searches.
* @return true if found and selected * @return true if found and selected
*/ */
public boolean selectRemoteObjects(Object src, ISubSystem subsystem, Object parentObject) public boolean selectRemoteObjects(Object src, ISubSystem subsystem, Object parentObject)
@ -4744,7 +4742,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* Recursively tries to find all filters affected by a given remote object. * Recursively tries to find all filters affected by a given remote object.
* *
* @param elementName the absolute name of the remote object to which we want to find a filters which result in it. * @param elementName the absolute name of the remote object to which we want to find a filters which result in it.
* @param subsystem. The subsystem which owns the remote resource. Necessary to scope the search for impacted filters. * @param subsystem The subsystem which owns the remote resource. Necessary to scope the search for impacted filters.
* @param matches the vector to populate with hits. Can be null, in which case a new vector is created. * @param matches the vector to populate with hits. Can be null, in which case a new vector is created.
* *
* @return Vector of FilterMatch objects for each affected filter * @return Vector of FilterMatch objects for each affected filter
@ -4768,7 +4766,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* after a remote resource change. * after a remote resource change.
* @param parent the parent item at which to start the search. * @param parent the parent item at which to start the search.
* @param elementName the absolute name of the remote element that has been created, changed, deleted or renamed. * @param elementName the absolute name of the remote element that has been created, changed, deleted or renamed.
* @param subsystem. The subsystem which owns the remote resource. Necessary to scope the search for impacted filters. * @param subsystem The subsystem which owns the remote resource. Necessary to scope the search for impacted filters.
* @param occurrences the vector to populate with hits * @param occurrences the vector to populate with hits
* *
* @return Vector of FilterMatch objects for each affected filter * @return Vector of FilterMatch objects for each affected filter

13
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/ISystemEditableRemoteObject.java
View file

@ -56,14 +56,14 @@ public interface ISystemEditableRemoteObject
/** /**
* Download the file. * Download the file.
* @param if the shell is null, no progress monitor will be shown * @param shell if the shell is null, no progress monitor will be shown
* @return true if successful, false if cancelled * @return true if successful, false if cancelled
*/ */
public boolean download(Shell shell) throws Exception; public boolean download(Shell shell) throws Exception;
/** /**
* Download the file. * Download the file.
* @param the progress monitor * @param monitor the progress monitor
* @return true if the operation was successful. false if the user cancels. * @return true if the operation was successful. false if the user cancels.
*/ */
public boolean download(IProgressMonitor monitor) throws Exception; public boolean download(IProgressMonitor monitor) throws Exception;
@ -144,20 +144,17 @@ public interface ISystemEditableRemoteObject
/** /**
* Return the absolute path on the remote system * Return the absolute path on the remote system.
* @return
*/ */
public String getAbsolutePath(); public String getAbsolutePath();
/** /**
* Return the subsystem for the edited object * Return the subsystem for the edited object.
* @return
*/ */
public ISubSystem getSubSystem(); public ISubSystem getSubSystem();
/** /**
* Returns whether the edited object exists * Returns whether the edited object exists.
* @return
*/ */
public boolean exists(); public boolean exists();

14
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/SystemView.java
View file

@ -796,7 +796,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
/** /**
* Helper method to collapse a node in the tree. * Helper method to collapse a node in the tree.
* Called when a currently expanded subsystem is disconnected. * Called when a currently expanded subsystem is disconnected.
* @param true if children should be deleted from memory so re-expand forces refresh. * @param forceRefresh true if children should be deleted from memory so re-expand forces refresh.
*/ */
public void collapseNode(Object element, boolean forceRefresh) public void collapseNode(Object element, boolean forceRefresh)
{ {
@ -1908,7 +1908,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
parentItem = findItem(parent); parentItem = findItem(parent);
if (parentItem == null) if (parentItem == null)
return Status.OK_STATUS; return Status.OK_STATUS;
if (multiSource.length > 0 && parentItem != null && parentItem instanceof Item ) if (multiSource.length > 0 && parentItem instanceof Item )
{ {
getControl().setRedraw(false); getControl().setRedraw(false);
collapseNode(parent, true); // collapse and flush gui widgets from memory collapseNode(parent, true); // collapse and flush gui widgets from memory
@ -2783,7 +2783,6 @@ public class SystemView extends TreeViewer implements ISystemTree,
else if (inputObj instanceof ISystemFilter) else if (inputObj instanceof ISystemFilter)
{ {
ISystemFilter filter = (ISystemFilter)inputObj; ISystemFilter filter = (ISystemFilter)inputObj;
if (filter == null) return null;
if (filter.getParentFilter() != null) if (filter.getParentFilter() != null)
return filter.getParentFilter(); return filter.getParentFilter();
else else
@ -3319,7 +3318,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* in order to uniquely find it. If not given this, we expand the first occurrence we find! * in order to uniquely find it. If not given this, we expand the first occurrence we find!
* @param remoteObject - either a remote object or a remote object absolute name * @param remoteObject - either a remote object or a remote object absolute name
* @param subsystem - the subsystem that owns the remote objects, to optimize searches. * @param subsystem - the subsystem that owns the remote objects, to optimize searches.
* @param parentobject - the parent that owns the remote objects, to optimize searches. Can * @param parentObject - the parent that owns the remote objects, to optimize searches. Can
* be an object or the absolute name of a remote object. * be an object or the absolute name of a remote object.
* @return the tree item of the remote object if found and expanded, else null * @return the tree item of the remote object if found and expanded, else null
*/ */
@ -3361,7 +3360,6 @@ public class SystemView extends TreeViewer implements ISystemTree,
} }
else // not given a parent to refine search with. Better have a subsystem!! else // not given a parent to refine search with. Better have a subsystem!!
{ {
remoteItem = null;
if (remoteObject instanceof String) if (remoteObject instanceof String)
remoteItem = findFirstRemoteItemReference((String)remoteObject, subsystem, (Item)null); remoteItem = findFirstRemoteItemReference((String)remoteObject, subsystem, (Item)null);
else else
@ -3385,7 +3383,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* Select a remote object or objects given the parent remote object (can be null) and subsystem (can be null) * Select a remote object or objects given the parent remote object (can be null) and subsystem (can be null)
* @param src - either a remote object, a remote object absolute name, or a vector of remote objects or remote object absolute names * @param src - either a remote object, a remote object absolute name, or a vector of remote objects or remote object absolute names
* @param subsystem - the subsystem that owns the remote objects, to optimize searches. * @param subsystem - the subsystem that owns the remote objects, to optimize searches.
* @param parentobject - the parent that owns the remote objects, to optimize searches. * @param parentObject - the parent that owns the remote objects, to optimize searches.
* @return true if found and selected * @return true if found and selected
*/ */
public boolean selectRemoteObjects(Object src, ISubSystem subsystem, Object parentObject) public boolean selectRemoteObjects(Object src, ISubSystem subsystem, Object parentObject)
@ -4744,7 +4742,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* Recursively tries to find all filters affected by a given remote object. * Recursively tries to find all filters affected by a given remote object.
* *
* @param elementName the absolute name of the remote object to which we want to find a filters which result in it. * @param elementName the absolute name of the remote object to which we want to find a filters which result in it.
* @param subsystem. The subsystem which owns the remote resource. Necessary to scope the search for impacted filters. * @param subsystem The subsystem which owns the remote resource. Necessary to scope the search for impacted filters.
* @param matches the vector to populate with hits. Can be null, in which case a new vector is created. * @param matches the vector to populate with hits. Can be null, in which case a new vector is created.
* *
* @return Vector of FilterMatch objects for each affected filter * @return Vector of FilterMatch objects for each affected filter
@ -4768,7 +4766,7 @@ public class SystemView extends TreeViewer implements ISystemTree,
* after a remote resource change. * after a remote resource change.
* @param parent the parent item at which to start the search. * @param parent the parent item at which to start the search.
* @param elementName the absolute name of the remote element that has been created, changed, deleted or renamed. * @param elementName the absolute name of the remote element that has been created, changed, deleted or renamed.
* @param subsystem. The subsystem which owns the remote resource. Necessary to scope the search for impacted filters. * @param subsystem The subsystem which owns the remote resource. Necessary to scope the search for impacted filters.
* @param occurrences the vector to populate with hits * @param occurrences the vector to populate with hits
* *
* @return Vector of FilterMatch objects for each affected filter * @return Vector of FilterMatch objects for each affected filter