From 0a23193b38706b59c5c95f15d74a6dcb8d7f57c7 Mon Sep 17 00:00:00 2001 From: Martin Oberhuber < martin.oberhuber@windriver.com> Date: Wed, 4 Jul 2007 16:49:06 +0000 Subject: [PATCH] [195392] Avoid setting port 0 in initializeSubSystem() --- .../subsystems/SubSystemConfiguration.java | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java index ccf02fea3b5..c118ff2c189 100644 --- a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java +++ b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java @@ -24,6 +24,7 @@ * Martin Oberhuber (Wind River) - [190231] Remove UI-only code from SubSystemConfiguration * Rupen Mardirossian (IBM) - [189434] Move Up/Down on Filters Error * Kevin Doyle (IBM) - [190445] Set Position of cloned event in cloneEvent() + * Martin Oberhuber (Wind River) - [195392] Avoid setting port 0 in initializeSubSystem() ********************************************************************************/ package org.eclipse.rse.core.subsystems; @@ -1164,15 +1165,15 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration public abstract ISubSystem createSubSystemInternal(IHost conn); /** - * Overridable method to initialize subsystems after creation. The default behaviour here is to - * set the subsystem's port property to 0, and to add to it a reference to the default filter pool for this - * subsystem configuration, if there is one. Typically subclasses call super().initializeSubSystem(...) - * to get this default behaviour, then extend it. + * Initialize subsystems after creation (Overridable). + * The default behavior is to add a reference to the default filter pool for this subsystem configuration, + * if there is one. Typically subclasses call super().initializeSubSystem(...) + * to get this default behavior, then extend it. * - *
The reason for the connect wizard pages parm is in case your subsystem configuration contributes a page to that wizard, + *
The reason for the connect wizard pages parameter is in case your subsystem configuration contributes a page to that wizard, * whose values are needed to set the subsystem's initial state. For example, you might decide to add a * page to the connection wizard to prompt for a JDBC Driver name. If so, when this method is called at - * the time a new connection is created apres the wizard, your page will have the user's value. You can + * the time a new connection is created after the wizard, your page will have the user's value. You can * thus use it here to initialize that subsystem property. Be use to use instanceof to find your particular * page. *
@@ -1187,11 +1188,6 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration */ protected void initializeSubSystem(ISubSystem ss, ISystemNewConnectionWizardPage[] yourNewConnectionWizardPages) { - IConnectorService connectorService = ss.getConnectorService(); - if (connectorService != null) - { - connectorService.setPort(0); - } if (supportsFilters()) { // --------------------------------------------