From 090fc94fa0c460745d9498c8b770ba5cac87627d Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Sat, 17 Nov 2018 20:41:49 +0000 Subject: [PATCH] Bug 536448: Require target platform bundles as minimum version Without setting dependent plug-ins to minimum version to match the target platform we are aiming for we can imply (and therefore let install) CDT into older versions of Eclipse where CDT does not actually work. This can be exposed in very odd ways, such as IllegalAccessError, when platform has allowed API changes. However, rather than update every single bundle in CDT, only the o.e.cdt.core/ui bundles are being updated as this should achieve the desired result without every other bundle needing to be touched. Change-Id: Idf166bc4f4a39ad5096386e24cbff234c0238900 --- .../org.eclipse.cdt.core/META-INF/MANIFEST.MF | 18 ++++---- core/org.eclipse.cdt.ui/META-INF/MANIFEST.MF | 42 +++++++++---------- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/core/org.eclipse.cdt.core/META-INF/MANIFEST.MF b/core/org.eclipse.cdt.core/META-INF/MANIFEST.MF index 0e5f58acfd6..cbd70328338 100644 --- a/core/org.eclipse.cdt.core/META-INF/MANIFEST.MF +++ b/core/org.eclipse.cdt.core/META-INF/MANIFEST.MF @@ -119,15 +119,15 @@ Export-Package: org.eclipse.cdt.core, org.eclipse.cdt.utils.xcoff, org.eclipse.cdt.utils.xcoff.parser Require-Bundle: org.eclipse.cdt.core.native;bundle-version="[5.10.0,6.0.0)";visibility:=reexport, - org.eclipse.core.contenttype;bundle-version="[3.3.0,4.0.0)", - org.eclipse.core.expressions;bundle-version="[3.2.0,4.0.0)", - org.eclipse.core.filebuffers;bundle-version="[3.2.0,4.0.0)", - org.eclipse.core.filesystem;bundle-version="[1.1.0,2.0.0)", - org.eclipse.core.resources;bundle-version="[3.2.0,4.0.0)", - org.eclipse.core.runtime;bundle-version="[3.8.0,4.0.0)", - org.eclipse.core.variables;bundle-version="[3.1.100,4.0.0)", - org.eclipse.ltk.core.refactoring;bundle-version="3.4.0", - org.eclipse.text;bundle-version="[3.2.0,4.0.0)", + org.eclipse.core.contenttype;bundle-version="[3.7.0,4.0.0)", + org.eclipse.core.expressions;bundle-version="[3.6.100,4.0.0)", + org.eclipse.core.filebuffers;bundle-version="[3.6.200,4.0.0)", + org.eclipse.core.filesystem;bundle-version="[1.7.100,2.0.0)", + org.eclipse.core.resources;bundle-version="[3.13.0,4.0.0)", + org.eclipse.core.runtime;bundle-version="[3.14.0,4.0.0)", + org.eclipse.core.variables;bundle-version="[3.4.100,4.0.0)", + org.eclipse.ltk.core.refactoring;bundle-version="[3.9.0,4.0.0)", + org.eclipse.text;bundle-version="[3.6.300,4.0.0)", com.ibm.icu;bundle-version="4.4.2", com.google.gson Bundle-ActivationPolicy: lazy diff --git a/core/org.eclipse.cdt.ui/META-INF/MANIFEST.MF b/core/org.eclipse.cdt.ui/META-INF/MANIFEST.MF index 44db3ec6eba..bf71692cda5 100644 --- a/core/org.eclipse.cdt.ui/META-INF/MANIFEST.MF +++ b/core/org.eclipse.cdt.ui/META-INF/MANIFEST.MF @@ -101,27 +101,27 @@ Export-Package: org.eclipse.cdt.internal.corext;x-internal:=true, org.eclipse.cdt.ui.wizards, org.eclipse.cdt.ui.wizards.conversion, org.eclipse.cdt.utils.ui.controls -Require-Bundle: org.eclipse.cdt.core;bundle-version="[5.2.0,7.0.0)", - org.eclipse.compare;bundle-version="[3.3.0,4.0.0)", - org.eclipse.core.expressions, - org.eclipse.core.filesystem;bundle-version="[1.1.0,2.0.0)", - org.eclipse.core.resources;bundle-version="[3.2.0,4.0.0)", - org.eclipse.core.runtime;bundle-version="[3.7.0,4.0.0)", - org.eclipse.core.variables;bundle-version="[3.1.100,4.0.0)", - org.eclipse.help;bundle-version="[3.2.0,4.0.0)", - org.eclipse.jface.text;bundle-version="[3.4.0,4.0.0)", - org.eclipse.ltk.core.refactoring;bundle-version="3.6.0", - org.eclipse.ltk.ui.refactoring;bundle-version="3.6.0", - org.eclipse.search;bundle-version="[3.2.0,4.0.0)", - org.eclipse.ui;bundle-version="[3.3.0,4.0.0)", - org.eclipse.ui.console;bundle-version="[3.1.100,4.0.0)", - org.eclipse.ui.editors;bundle-version="[3.3.0,4.0.0)", - org.eclipse.ui.forms;bundle-version="[3.2.0,4.0.0)", - org.eclipse.ui.ide;bundle-version="[3.3.0,4.0.0)", - org.eclipse.ui.navigator;bundle-version="[3.2.0,4.0.0)", - org.eclipse.ui.navigator.resources;bundle-version="3.3.100", - org.eclipse.ui.views;bundle-version="[3.2.0,4.0.0)", - org.eclipse.ui.workbench.texteditor;bundle-version="[3.5.0,4.0.0)", +Require-Bundle: org.eclipse.cdt.core;bundle-version="[6.6.0,7.0.0)", + org.eclipse.compare;bundle-version="[3.7.200,4.0.0)", + org.eclipse.core.expressions;bundle-version="[3.6.100,4.0.0)", + org.eclipse.core.filesystem;bundle-version="[1.7.100,2.0.0)", + org.eclipse.core.resources;bundle-version="[3.13.0,4.0.0)", + org.eclipse.core.runtime;bundle-version="[3.14.0,4.0.0)", + org.eclipse.core.variables;bundle-version="[3.4.100,4.0.0)", + org.eclipse.help;bundle-version="[3.8.100,4.0.0)", + org.eclipse.jface.text;bundle-version="[3.13.0,4.0.0)", + org.eclipse.ltk.core.refactoring;bundle-version="[3.9.0,4.0.0)", + org.eclipse.ltk.ui.refactoring;bundle-version="[3.9.100,4.0.0)", + org.eclipse.search;bundle-version="[3.11.200,4.0.0)", + org.eclipse.ui;bundle-version="[3.109.100,4.0.0)", + org.eclipse.ui.console;bundle-version="[3.8.0,4.0.0)", + org.eclipse.ui.editors;bundle-version="[3.11.100,4.0.0)", + org.eclipse.ui.forms;bundle-version="[3.7.200,4.0.0)", + org.eclipse.ui.ide;bundle-version="[3.14.0,4.0.0)", + org.eclipse.ui.navigator;bundle-version="[3.7.100,4.0.0)", + org.eclipse.ui.navigator.resources;bundle-version="[3.6.100,4.0.0)", + org.eclipse.ui.views;bundle-version="[3.9.100,4.0.0)", + org.eclipse.ui.workbench.texteditor;bundle-version="[3.11.0,4.0.0)", com.ibm.icu;bundle-version="4.4.2", org.eclipse.e4.ui.css.swt.theme, org.eclipse.tools.templates.ui;bundle-version="1.1.0"