From 090f1b7bae70e83a14f130364ae3df21979c6f9a Mon Sep 17 00:00:00 2001
From: Martin Oberhuber < martin.oberhuber@windriver.com>
Date: Tue, 18 Jul 2006 11:39:48 +0000
Subject: [PATCH] Update readme and comments for daytime

---
 .../org.eclipse.rse.examples.daytime/readme.txt     | 13 +++++++------
 .../connectorservice/DaytimeConnectorService.java   |  5 +++--
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/rse/examples/org.eclipse.rse.examples.daytime/readme.txt b/rse/examples/org.eclipse.rse.examples.daytime/readme.txt
index 7ddd909b827..efee2d91ac9 100644
--- a/rse/examples/org.eclipse.rse.examples.daytime/readme.txt
+++ b/rse/examples/org.eclipse.rse.examples.daytime/readme.txt
@@ -32,14 +32,15 @@ AbstractSystemViewAdapter. The DaytimeService is rather simple, since
 queries are fast enough to use a connectionless service.
 
 __Known Issues:__
-* Entering Username and Password should not be required.
-* Manual Refresh after connect should not be required.
 * When something goes wrong during connect, the error message 
   does not give enough information about the cause of the error.
-* The example defines a Service for its task; there might be 
-  applications where this is not required or desired. A simpler 
-  example should be provided that only defines a Subsystem but
-  no Service, ConnectorService or ConnectorServiceManager.
+* Should define a second service, that uses UDP for getting the
+  daytime. This would show the advantages of ServiceSubsystem.
+  The Tutorial example (developer) is good for showing service-less
+  subsystems.
+* ConnectorService / ConnectorServiceManager should exist in a 
+  simpler default implementation such that not every new service
+  or subsystem implements the same over and over again (bug 150928).
 
 __Enabling the Daytime Service on a Remote Host:__
 In order for the example to work, the service on TCP port 13 must be 
diff --git a/rse/examples/org.eclipse.rse.examples.daytime/src/org/eclipse/rse/examples/daytime/connectorservice/DaytimeConnectorService.java b/rse/examples/org.eclipse.rse.examples.daytime/src/org/eclipse/rse/examples/daytime/connectorservice/DaytimeConnectorService.java
index 3cf02a2402e..0375465fce9 100644
--- a/rse/examples/org.eclipse.rse.examples.daytime/src/org/eclipse/rse/examples/daytime/connectorservice/DaytimeConnectorService.java
+++ b/rse/examples/org.eclipse.rse.examples.daytime/src/org/eclipse/rse/examples/daytime/connectorservice/DaytimeConnectorService.java
@@ -55,8 +55,9 @@ public class DaytimeConnectorService extends AbstractConnectorService {
 		}
 		//if no exception is thrown, we consider ourselves connected!
 		fIsConnected = true;
-		//TODO force a refresh of the Viewer in order to show the resource
-		// Fire comm event to signal state changed
+		// Fire comm event to signal state changed -- 
+		// Not really necessary since SubSystem.connect(Shell, boolean) does
+		// SystemRegistry.connectedStatusChange(this, true, false) at the end
 		notifyConnection();
 	}