diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentToItselfChecker.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentToItselfChecker.java index 7be5b8857d1..f216659e03f 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentToItselfChecker.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentToItselfChecker.java @@ -6,7 +6,7 @@ * http://www.eclipse.org/legal/epl-v10.html * * Contributors: - * Severin Gehwolf - initial API and implementation + * Severin Gehwolf - initial API and implementation *******************************************************************************/ package org.eclipse.cdt.codan.internal.checkers; @@ -17,16 +17,16 @@ import org.eclipse.cdt.core.dom.ast.IASTExpression; import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit; /** - * Checker that find assignment to itself cases, such a + * Checker that finds assignment to itself cases, such a * a = a. It can produce some false positives such as - * a[f()]=a[f()] - but who write codes like that? + * a[f()]=a[f()] - but who writes code like that? */ public class AssignmentToItselfChecker extends AbstractIndexAstChecker { private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.AssignmentToItselfProblem"; //$NON-NLS-1$ @Override public void processAst(IASTTranslationUnit ast) { - // traverse the ast using the visitor pattern. + // Traverse the ast using the visitor pattern. ast.accept(new ASTVisitor() { { // constructor shouldVisitExpressions = true; @@ -49,7 +49,7 @@ public class AssignmentToItselfChecker extends AbstractIndexAstChecker { String op2 = binExpr.getOperand2().getRawSignature(); String expr = binExpr.getRawSignature(); return op1.equals(op2) - // when macro is used RawSignature returns macro name, see Bug 321933 + // When macro is used, RawSignature returns macro name, see bug 321933 && !op1.equals(expr); } } diff --git a/codan/org.eclipse.cdt.codan.ui.cxx/src/org/eclipse/cdt/codan/internal/ui/cxx/CodanCReconciler.java b/codan/org.eclipse.cdt.codan.ui.cxx/src/org/eclipse/cdt/codan/internal/ui/cxx/CodanCReconciler.java index 998aaac1978..7f25b360198 100644 --- a/codan/org.eclipse.cdt.codan.ui.cxx/src/org/eclipse/cdt/codan/internal/ui/cxx/CodanCReconciler.java +++ b/codan/org.eclipse.cdt.codan.ui.cxx/src/org/eclipse/cdt/codan/internal/ui/cxx/CodanCReconciler.java @@ -38,9 +38,6 @@ public class CodanCReconciler implements ICReconcilingListener { editor.removeReconcileListener(this); } - /** - * - */ private void initialize() { // nothing? }