mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 17:56:01 +02:00
Code Issues Wiki Activity

bug 236556: Did a little refactoring introducing BUTTON_INDEX constants instead hardcoded numbers

Browse source
This commit is contained in:
Andrew Gvozdev 2009-07-16 20:45:58 +00:00
parent ed6faa6fc9
commit 0578b35b87
1 changed files with 103 additions and 93 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractLangsListTab.java
View file

@ -90,6 +90,14 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
protected ICLanguageSetting [] ls; // all languages known protected ICLanguageSetting [] ls; // all languages known
private boolean fHadSomeModification; private boolean fHadSomeModification;
private static final int BUTTON_INDEX_ADD = 0;
private static final int BUTTON_INDEX_EDIT = 1;
private static final int BUTTON_INDEX_DELETE = 2;
private static final int BUTTON_INDEX_EXPORT = 3;
// there is a separator instead of button #4
private static final int BUTTON_INDEX_MOVEUP = 5;
private static final int BUTTON_INDEX_MOVEDOWN = 6;
protected final static String[] BUTTONS = {ADD_STR, EDIT_STR, DEL_STR, protected final static String[] BUTTONS = {ADD_STR, EDIT_STR, DEL_STR,
UIMessages.getString("AbstractLangsListTab.2"), //$NON-NLS-1$ UIMessages.getString("AbstractLangsListTab.2"), //$NON-NLS-1$
null, MOVEUP_STR, MOVEDOWN_STR }; null, MOVEUP_STR, MOVEDOWN_STR };
@ -168,6 +176,7 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
public void widgetSelected(SelectionEvent e) { public void widgetSelected(SelectionEvent e) {
updateButtons(); updateButtons();
} }
@Override @Override
public void widgetDefaultSelected(SelectionEvent e) { public void widgetDefaultSelected(SelectionEvent e) {
if (buttonIsEnabled(1) && table.getSelectionIndex() != -1) if (buttonIsEnabled(1) && table.getSelectionIndex() != -1)
@ -193,9 +202,11 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
public void mouseDoubleClick(MouseEvent e) { public void mouseDoubleClick(MouseEvent e) {
CDTPrefUtil.spinDMode(); CDTPrefUtil.spinDMode();
update(); update();
}}); }
});
showBIButton = setupCheck(usercomp, UIMessages.getString("AbstractLangsListTab.0"), 1, GridData.FILL_HORIZONTAL); //$NON-NLS-1$ showBIButton = setupCheck(usercomp,
UIMessages.getString("AbstractLangsListTab.0"), 1, GridData.FILL_HORIZONTAL); //$NON-NLS-1$
showBIButton.addSelectionListener(new SelectionAdapter() { showBIButton.addSelectionListener(new SelectionAdapter() {
@Override @Override
public void widgetSelected(SelectionEvent e) { public void widgetSelected(SelectionEvent e) {
@ -211,7 +222,8 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
public void mouseDoubleClick(MouseEvent e) { public void mouseDoubleClick(MouseEvent e) {
CDTPrefUtil.spinWMode(); CDTPrefUtil.spinWMode();
updateLbs(null, lb2); updateLbs(null, lb2);
}}); }
});
additionalTableSet(); additionalTableSet();
initButtons((getKind() == ICSettingEntry.MACRO) ? BUTTSYM : BUTTONS); initButtons((getKind() == ICSettingEntry.MACRO) ? BUTTSYM : BUTTONS);
@ -236,11 +248,11 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
if (ent.isReadOnly()) canEdit = false; if (ent.isReadOnly()) canEdit = false;
if (ent.isReadOnly()) canDelete = false; if (ent.isReadOnly()) canDelete = false;
if (exported.contains(ent)) if (exported.contains(ent))
buttonSetText(3, UIMessages.getString("AbstractLangsListTab.4")); //$NON-NLS-1$ buttonSetText(BUTTON_INDEX_EXPORT, UIMessages.getString("AbstractLangsListTab.4")); //$NON-NLS-1$
else else
buttonSetText(3, UIMessages.getString("AbstractLangsListTab.2")); //$NON-NLS-1$ buttonSetText(BUTTON_INDEX_EXPORT, UIMessages.getString("AbstractLangsListTab.2")); //$NON-NLS-1$
} else { } else {
buttonSetText(3, UIMessages.getString("AbstractLangsListTab.2")); //$NON-NLS-1$ buttonSetText(BUTTON_INDEX_EXPORT, UIMessages.getString("AbstractLangsListTab.2")); //$NON-NLS-1$
} }
boolean canMoveUp = false; boolean canMoveUp = false;
boolean canMoveDown = false; boolean canMoveDown = false;
@ -252,13 +264,12 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
ent = (ICLanguageSettingEntry)(table.getItem(index+1).getData()); ent = (ICLanguageSettingEntry)(table.getItem(index+1).getData());
if (ent.isBuiltIn()) canMoveDown = false; // cannot exchange with built in if (ent.isBuiltIn()) canMoveDown = false; // cannot exchange with built in
} }
buttonSetEnabled(0, canAdd); // add buttonSetEnabled(BUTTON_INDEX_ADD, canAdd);
buttonSetEnabled(1, canEdit); // edit buttonSetEnabled(BUTTON_INDEX_EDIT, canEdit);
buttonSetEnabled(2, canDelete); // delete buttonSetEnabled(BUTTON_INDEX_DELETE, canDelete);
buttonSetEnabled(3, canExport && !page.isMultiCfg()); // export buttonSetEnabled(BUTTON_INDEX_EXPORT, canExport && !page.isMultiCfg());
// there is a separator instead of button #4 buttonSetEnabled(BUTTON_INDEX_MOVEUP, canMoveUp && !page.isMultiCfg());
buttonSetEnabled(5, canMoveUp && !page.isMultiCfg()); // up buttonSetEnabled(BUTTON_INDEX_MOVEDOWN, canMoveDown && !page.isMultiCfg());
buttonSetEnabled(6, canMoveDown && !page.isMultiCfg()); // down
} }
private Tree addTree(Composite comp) { private Tree addTree(Composite comp) {
@ -271,32 +282,32 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
public void widgetSelected(SelectionEvent e) { public void widgetSelected(SelectionEvent e) {
TreeItem[] items = langTree.getSelection(); TreeItem[] items = langTree.getSelection();
if (items.length > 0) { if (items.length > 0) {
ICLanguageSetting ls = (ICLanguageSetting)items[0].getData(); ICLanguageSetting ls = (ICLanguageSetting) items[0].getData();
if (ls != null) { if (ls != null) {
lang = ls; lang = ls;
update(); update();
} }
} }
}}); }
});
langTree.addPaintListener(new PaintListener() { langTree.addPaintListener(new PaintListener() {
public void paintControl(PaintEvent e) { public void paintControl(PaintEvent e) {
int x = langTree.getBounds().width - 5; int x = langTree.getBounds().width - 5;
if (langCol.getWidth() != x) if (langCol.getWidth() != x)
langCol.setWidth(x); langCol.setWidth(x);
}}); }
});
langCol = new TreeColumn(langTree, SWT.NONE); langCol = new TreeColumn(langTree, SWT.NONE);
langCol.setText(UIMessages.getString("AbstractLangsListTab.1")); //$NON-NLS-1$ langCol.setText(UIMessages.getString("AbstractLangsListTab.1")); //$NON-NLS-1$
langCol.setWidth(200); langCol.setWidth(200);
langCol.setResizable(false); langCol.setResizable(false);
langTree.getAccessible().addAccessibleListener( langTree.getAccessible().addAccessibleListener(new AccessibleAdapter() {
new AccessibleAdapter() {
@Override @Override
public void getName(AccessibleEvent e) { public void getName(AccessibleEvent e) {
e.result = UIMessages.getString("AbstractLangsListTab.1"); //$NON-NLS-1$ e.result = UIMessages.getString("AbstractLangsListTab.1"); //$NON-NLS-1$
} }
} });
);
return langTree; return langTree;
} }
@ -512,18 +523,18 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
int ids[] = table.getSelectionIndices(); int ids[] = table.getSelectionIndices();
switch (i) { switch (i) {
case 0: // add case BUTTON_INDEX_ADD:
toAllCfgs = false; toAllCfgs = false;
toAllLang = false; toAllLang = false;
performAdd(doAdd()); performAdd(doAdd());
break; break;
case 1: // edit case BUTTON_INDEX_EDIT:
performEdit(n); performEdit(n);
break; break;
case 2: // delete case BUTTON_INDEX_DELETE:
performDelete(n); performDelete(n);
break; break;
case 3: // toggle export case BUTTON_INDEX_EXPORT:
if (n == -1) return; if (n == -1) return;
for (int x=ids.length-1; x>=0; x--) { for (int x=ids.length-1; x>=0; x--) {
old = (ICLanguageSettingEntry)(table.getItem(ids[x]).getData()); old = (ICLanguageSettingEntry)(table.getItem(ids[x]).getData());
@ -536,13 +547,12 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
updateExport(); updateExport();
update(); update();
break; break;
// there is a separator instead of button #4 case BUTTON_INDEX_MOVEUP:
case 5: // move up case BUTTON_INDEX_MOVEDOWN:
case 6: // move down
old = (ICLanguageSettingEntry)(table.getItem(n).getData()); old = (ICLanguageSettingEntry)(table.getItem(n).getData());
int x = shownEntries.indexOf(old); int x = shownEntries.indexOf(old);
if (x < 0) break; if (x < 0) break;
if (i == 6) x++; // "down" simply means "up underlying item" if (i == BUTTON_INDEX_MOVEDOWN) x++; // "down" simply means "up underlying item"
old = shownEntries.get(x); old = shownEntries.get(x);
ICLanguageSettingEntry old2 = shownEntries.get(x - 1); ICLanguageSettingEntry old2 = shownEntries.get(x - 1);
shownEntries.remove(x); shownEntries.remove(x);
@ -551,7 +561,7 @@ public abstract class AbstractLangsListTab extends AbstractCPropertyTab {
shownEntries.add(x, old2); shownEntries.add(x, old2);
setSettingEntries(getKind(), shownEntries, false); setSettingEntries(getKind(), shownEntries, false);
update(i == 5 ? -1 : 1); update(i == BUTTON_INDEX_MOVEUP ? -1 : 1);
break; break;
default: default:
break; break;