From 03ad4169dd14a43085db8679c1f9f1e001342f13 Mon Sep 17 00:00:00 2001 From: David Dykstal Date: Fri, 23 May 2008 20:08:18 +0000 Subject: [PATCH] [233678] TVT34:TCT210: RU: concatenated string "Root Connections" https://bugs.eclipse.org/bugs/show_bug.cgi?id=233678 --- .../org/eclipse/rse/internal/ui/SystemResources.java | 3 +++ .../rse/internal/ui/SystemResources.properties | 2 ++ .../rse/internal/ui/view/SystemTableViewPart.java | 11 +++++------ 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.java index ac6cb411555..08e9f4fbd9b 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.java @@ -23,6 +23,7 @@ * David Dykstal (IBM) - [216858] Need the ability to Import/Export RSE connections for sharing * David Dykstal (IBM) - [231943] Make "true" and "false" translatable on SystemTypeFieldEditor * David Dykstal (IBM) - [188150] adding "go up one level" tooltip + * David Dykstal (IBM) - [233678] title string is constructed by concatenation, should be substituted *******************************************************************************/ package org.eclipse.rse.internal.ui; @@ -1036,6 +1037,8 @@ public class SystemResources extends NLS public static String SystemImportConnectionAction_UnexpectedException; + public static String SystemTableViewPart_title; + public static String SystemTypeFieldEditor_false; public static String SystemTypeFieldEditor_true; diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.properties b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.properties index 4b679261717..ca1223afa01 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.properties +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/SystemResources.properties @@ -25,6 +25,7 @@ # David Dykstal (IBM) - [216858] Need the ability to Import/Export RSE connections for sharing # David Dykstal (IBM) - [231943] Make true and false translatable on SystemTypeFieldEditor # David Dykstal (IBM) - [188150] adding "go up one level" tooltip +# David Dykstal (IBM) - [233678] title string is constructed by concatenation, should be substituted ################################################################################ # NLS_MESSAGEFORMAT_VAR @@ -1087,5 +1088,6 @@ SystemImportConnectionAction_FileNotFoundCondition=File {0} does not exist. SystemImportConnectionAction_FileNotReadableCondition=You do not have permission to read file {0}. SystemImportConnectionAction_ImportJobName=RSE Connection Import Job SystemImportConnectionAction_UnexpectedException=unexpected exception +SystemTableViewPart_title={0} {1} SystemTypeFieldEditor_false=false SystemTypeFieldEditor_true=true diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java index a5b9f8922f6..ec1c5d1d1ec 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java @@ -38,6 +38,7 @@ * David Dykstal (IBM) - [188150] adding "go up one level" tooltip * David McKnight (IBM) - [232320] remote system details view restore problem * David McKnight (IBM) - [233578] Promptable Filter Displayed 3 times when clicking cancel + * David Dykstal (IBM) - [233678] title string is constructed by concatenation, should be substituted *******************************************************/ package org.eclipse.rse.internal.ui.view; @@ -139,6 +140,8 @@ import org.eclipse.ui.part.ViewPart; import org.eclipse.ui.views.properties.IPropertyDescriptor; import org.osgi.framework.Bundle; +import com.ibm.icu.text.MessageFormat; + /** * Comment goes here */ @@ -1575,12 +1578,8 @@ public class SystemTableViewPart extends ViewPart { String type = va.getType(object); String name = va.getName(object); - //setPartName(type + " " + name); - - setContentDescription(type + " "+ name); //$NON-NLS-1$ - - //SystemTableViewProvider provider = (SystemTableViewProvider) _viewer.getContentProvider(); - //setTitleImage(provider.getImage(object)); + String title = MessageFormat.format(SystemResources.SystemTableViewPart_title, new String[] {type, name}); + setContentDescription(title); } } }