From 01bfa62a4d3c7d36b7af1662ab0c421e1be3db04 Mon Sep 17 00:00:00 2001 From: Alena Laskavaia Date: Wed, 3 Jun 2015 10:53:32 -0400 Subject: [PATCH] launchbar: target config provider lc working copies bugs per target config provider adds working copy into cache on change notifications which creates problems a) they never cleaned up b) now when its searching its picking a wrong config (wc) causing it to return invalid config fix push up higher in launch bar itself, no point propagating launch change notifications from working copies Change-Id: I3b7bc94f3ef6ab385fc43cc5482ab4c9b943e8fa --- .../eclipse/launchbar/core/internal/LaunchBarManager.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bundles/org.eclipse.launchbar.core/src/org/eclipse/launchbar/core/internal/LaunchBarManager.java b/bundles/org.eclipse.launchbar.core/src/org/eclipse/launchbar/core/internal/LaunchBarManager.java index 998a8722d32..9bad6cdba57 100644 --- a/bundles/org.eclipse.launchbar.core/src/org/eclipse/launchbar/core/internal/LaunchBarManager.java +++ b/bundles/org.eclipse.launchbar.core/src/org/eclipse/launchbar/core/internal/LaunchBarManager.java @@ -815,6 +815,11 @@ public class LaunchBarManager implements ILaunchBarManager, IRemoteConnectionCha @Override public void launchConfigurationChanged(ILaunchConfiguration configuration) { + // we have to ignore notifications from working copies, otherwise + // we will get thousand of events and we don't track working copies + // (add/remove events are not sent for WCs) + if (configuration.isWorkingCopy()) + return; for (LaunchDescriptorTypeInfo descTypeInfo : orderedDescriptorTypes) { for (LaunchConfigProviderInfo providerInfo : configProviders.get(descTypeInfo.getId())) { try {