mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

[releng] Add some more help in error messages when code cleanliness fails

Browse source 
Change-Id: I5cea3eb02e4809e591e3160358b7f6b06feabefa
This commit is contained in:
Jonah Graham 2020-04-17 08:40:13 -04:00
parent eeebe5234c
commit 00cf160745
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
releng/scripts/check_code_cleanliness.sh
View file

@ -108,12 +108,14 @@ fi
if test -z "$(git status -s)"; then if test -z "$(git status -s)"; then
echo "Tree looks clean!" echo "Tree looks clean!"
else else
echo "Tree is dirty - something needs to be cleaned up in your commit" echo "Tree is dirty - something needs to be cleaned up in your commit (more info below)"
echo "Result of git status" echo "Result of git status"
git status git status
echo "Result of git diff" echo "Result of git diff"
git diff git diff
echo "Tree is dirty - something needs to be cleaned up in your commit (see above for git status/diff)" echo "Tree is dirty - something needs to be cleaned up in your commit (see above for git status/diff). The 'something'"
echo "is likely a misformatted file, extra whitespace at end of line, or something similar. The diff above"
echo "shows what changes you need to apply to your patch to get it past the code cleanliness check."
exit 1 exit 1
fi fi
@ -146,8 +148,9 @@ else
echo "Please bump service segment by 100 if on master branch" echo "Please bump service segment by 100 if on master branch"
echo "See: https://wiki.eclipse.org/Version_Numbering#When_to_change_the_service_segment" echo "See: https://wiki.eclipse.org/Version_Numbering#When_to_change_the_service_segment"
else else
echo "Maven 'check all versions have been bumped appropriately' failed!" echo "Maven 'check all versions have been bumped appropriately' failed! Please see the"
echo "The log of this build is part of the artifacts" echo "log of the failed maven run which is available as part of the artifacts in a"
echo "file called baseline-compare-and-replace.log"
fi fi
cp ${logfile} baseline-compare-and-replace.log cp ${logfile} baseline-compare-and-replace.log
exit 1 exit 1