mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

[241024] - [view model] Most views stop refereshing after a breakpoint hit after a long operation (e.g. sleep)

Browse source
This commit is contained in:
Pawel Piech 2008-07-16 18:34:24 +00:00
parent bc15b2355b
commit 0006e4ba15
3 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/AbstractVMProvider.java
View file

@ -566,9 +566,21 @@ abstract public class AbstractVMProvider implements IVMProvider, IVMEventListene
} }
} }
} }
if (proxy == null) { if (proxy == null) {
proxy = createModelProxyStrategy(element); proxy = createModelProxyStrategy(element);
getActiveModelProxies().add(proxy); getActiveModelProxies().add(proxy);
} else if (proxy.isDisposed()) {
// DSF is capable of re-using old proxies which were previously
// disposed. However, the viewer which installs a proxy using
// a background job to install the proxy calls
// IModelProxy.isDisposed(), to check whether the proxy was disposed
// before it could be installed. We need to clear the disposed flag
// of the re-used proxy here, otherwise the proxy will never get used.
// Calling init here will cause the init() method to be called twice
// so the IVMModelProxy needs to be prepared for that.
// See bug 241024.
proxy.init(context);
} }
return proxy; return proxy;
} }

3
plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/IVMModelProxy.java
View file

@ -18,6 +18,9 @@ import org.eclipse.debug.internal.ui.viewers.model.provisional.IModelProxy;
* View Model extension to the platform IModelProxy interface. This extension * View Model extension to the platform IModelProxy interface. This extension
* allows the IVMProvider implementation to delegate the model proxy implementation * allows the IVMProvider implementation to delegate the model proxy implementation
* into a separate object. * into a separate object.
* <br/>
* Note: The IVMModelProxy.init() may be called twice when installed, as a
* workaround for bug 241024.
*/ */
@SuppressWarnings("restriction") @SuppressWarnings("restriction")
public interface IVMModelProxy extends IModelProxy { public interface IVMModelProxy extends IModelProxy {

12
plugins/org.eclipse.dd.dsf.ui/src/org/eclipse/dd/dsf/ui/viewmodel/update/AbstractCachingVMProvider.java
View file

@ -601,11 +601,23 @@ public class AbstractCachingVMProvider extends AbstractVMProvider implements ICa
IVMModelProxy next = itr.next(); IVMModelProxy next = itr.next();
if (next != null && next.getRootElement().equals(element)) { if (next != null && next.getRootElement().equals(element)) {
proxy = next; proxy = next;
break;
} }
} }
if (proxy == null) { if (proxy == null) {
proxy = createModelProxyStrategy(element); proxy = createModelProxyStrategy(element);
getActiveModelProxies().add(proxy); getActiveModelProxies().add(proxy);
} else if (proxy.isDisposed()) {
// DSF is capable of re-using old proxies which were previously
// disposed. However, the viewer which installs a proxy using
// a background job to install the proxy calls
// IModelProxy.isDisposed(), to check whether the proxy was disposed
// before it could be installed. We need to clear the disposed flag
// of the re-used proxy here, otherwise the proxy will never get used.
// Calling init here will cause the init() method to be called twice
// so the IVMModelProxy needs to be prepared for that.
// See bug 241024.
proxy.init(context);
} }
return proxy; return proxy;
} }