From 99afbe2cf3c675437f123aafb456a345b9545eee Mon Sep 17 00:00:00 2001 From: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Date: Thu, 21 Oct 2021 08:16:17 +0100 Subject: [PATCH] maintainers-guide: refresh (#6397) --- contributing-guides/maintainers-guide.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contributing-guides/maintainers-guide.md b/contributing-guides/maintainers-guide.md index 98b17a1f6a..6160fd9a71 100644 --- a/contributing-guides/maintainers-guide.md +++ b/contributing-guides/maintainers-guide.md @@ -56,9 +56,9 @@ as a guideline for current and future maintainers. - PRs should be merged once they (1) **pass the automated tests** (GitHub Actions, CLA signing, etc.), - (2) have the **review comments addressed**, and - (3) get **approved reviews by two maintainers** - (the second maintainer can perform the merge immediately after accepting.) + (2) have the **review comments addressed**, + (3) get **approved reviews by two maintainers**, (the second maintainer can merge immediately after approving) and + (4) have been open for at least **24 hours** unless the changes are trivial - If a PR fails to get a review from a second maintainer after a few days, the first maintainer should ping others for review. If it still lingers around @@ -71,7 +71,7 @@ as a guideline for current and future maintainers. and proceed with the merge process. - If a PR **stops getting feedback from the submitter** and is marked as stale - by [probot-stale](../.github/stale.yml), + by [probot-stale](../.github/workflows/stale.yml), any maintainer can choose to take over the PR and make the necessary changes to get the content ready for merging.