lilith/tldr
1
0
Fork 0
mirror of https://github.com/tldr-pages/tldr.git synced 2025-04-22 09:02:08 +02:00
Code Activity

maintainers-guide: simplify description of CODEOWNERS (#13936)

Browse source
This commit is contained in:
Lena 2024-10-02 13:23:19 +02:00 • committed by GitHub
parent 2948595386
commit 749abdbcc4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
contributing-guides/maintainers-guide.md
View file

@ -63,9 +63,9 @@ for the behavior expected of tldr-pages maintainers.
- It is suggested to wait for a few hours before merging a PR with new additions to English pages. This is to allow other maintainers to review the changes and provide feedback. - It is suggested to wait for a few hours before merging a PR with new additions to English pages. This is to allow other maintainers to review the changes and provide feedback.
- If a PR is non-English and there are automatic reviewers added via [CODEOWNERS](https://github.com/tldr-pages/tldr/blob/main/.github/CODEOWNERS), the PR at least needs one approval from one of the CODEOWNERS. - If a PR is non-English and there are automatic reviewers added via [CODEOWNERS](https://github.com/tldr-pages/tldr/blob/main/.github/CODEOWNERS), the PR at least needs one approval from one of the CODEOWNERS.
- If a PR fails to get a review from one of the CODEOWNERS after a few days, the first maintainer should ping the CODEOWNERS for review. - If a PR fails to get a review from one of the CODEOWNERS after a few days, the first maintainer should ping the CODEOWNERS for review.
- If it still lingers around for **over 10 days upto 2 weeks without a approval from one of the CODEOWNERS**, the PR can be merged if it has two approvals. - If it still lingers around for **over 10 days without an approval from one of the CODEOWNERS**, the PR can be merged if it has two approvals.
- If it only has one approval, please read the next point. - If it only has one approval, please read the next point.
- If a PR fails to get a review from a second maintainer after a few days, - If a PR fails to get a review from a second maintainer after a few days,
the first maintainer should ping others for review. the first maintainer should ping others for review.