From 13facb7c696f6165217972fc5b7962d474465a9f Mon Sep 17 00:00:00 2001 From: "K.B.Dharun Krishna" Date: Sun, 5 Nov 2023 23:29:16 +0530 Subject: [PATCH] MAINTAINERS Guide: remove minimum merge wait time requirement (#11391) --- contributing-guides/maintainers-guide.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/contributing-guides/maintainers-guide.md b/contributing-guides/maintainers-guide.md index 10da6a740c..e95bc9610c 100644 --- a/contributing-guides/maintainers-guide.md +++ b/contributing-guides/maintainers-guide.md @@ -58,8 +58,7 @@ for the behavior expected of tldr-pages maintainers. - PRs should be merged once they (1) **pass the automated tests** (GitHub Actions, CLA signing, etc.), (2) have the **review comments addressed**, - (3) get **approved reviews by two maintainers**, (the second maintainer can merge immediately after approving) and - (4) have been open for at least **24 hours** unless the changes are trivial + (3) get **approved reviews by two maintainers** (the second maintainer can merge immediately after approving). - If a PR fails to get a review from a second maintainer after a few days, the first maintainer should ping others for review. If it still lingers around