lilith/jami-client-qt
1
0
Fork 0
mirror of https://git.jami.net/savoirfairelinux/jami-client-qt.git synced 2025-09-10 12:03:18 +02:00
Code Activity

settings: remove RTP fallback

Browse source 
As not present in other clients and if SDES is enabled, all calls
must be in SRTP. Else UX would be unclear.

Change-Id: If756f8738ef08109aa7fbf8cbcade3b4f4792093
GitLab: #1263
This commit is contained in:
Sébastien Blin 2023-07-17 15:47:13 -04:00
parent f53c2be978
commit 452d49a439
6 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/app/constant/JamiStrings.qml
View file

@ -100,7 +100,6 @@ Item {
// AdvancedSIPSecuritySettings && AdvancedJamiSecuritySettings
property string security: qsTr("Security")
property string enableSDES: qsTr("Enable SDES key exchange")
property string fallbackRTP: qsTr("Allow fallback on RTP")
property string encryptNegotiation: qsTr("Encrypt negotiation (TLS)")
property string caCertificate: qsTr("CA certificate")
property string userCertificate: qsTr("User certificate")

1
src/app/currentaccount.cpp
View file

@ -179,7 +179,6 @@ CurrentAccount::updateData()
// SRTP
set_enableSRTP(accConfig.SRTP.enable, true);
set_rtpFallbackSRTP(accConfig.SRTP.rtpFallback, true);
set_keyExchangeSRTP(accConfig.SRTP.keyExchange, true);
// TURN

1
src/app/currentaccount.h
View file

@ -160,7 +160,6 @@ class CurrentAccount final : public QObject
// SRTP settings
QML_ACCOUNT_CONFIG_CATEGORY_SETTINGS_PROPERTY(bool, enable, SRTP)
QML_ACCOUNT_CONFIG_CATEGORY_SETTINGS_PROPERTY(bool, rtpFallback, SRTP)
QML_ACCOUNT_CONFIG_CATEGORY_SETTINGS_PROPERTY(lrc::api::account::KeyExchangeProtocol,
keyExchange,
SRTP)

8
src/app/settingsview/components/AdvancedSIPSecuritySettings.qml
View file

@ -67,14 +67,6 @@ ColumnLayout {
onSwitchToggled: CurrentAccount.keyExchange_SRTP = Number(checked)
}
ToggleSwitch {
id: fallbackRTPToggle
labelText: JamiStrings.fallbackRTP
checked: CurrentAccount.rtpFallback_SRTP
onSwitchToggled: CurrentAccount.rtpFallback_SRTP = checked
}
ToggleSwitch {
id: encryptNegotitationToggle

2
src/libclient/accountmodel.cpp
View file

@ -902,7 +902,6 @@ account::Info::fromDetails(const MapStringString& details)
? account::KeyExchangeProtocol::NONE
: account::KeyExchangeProtocol::SDES;
confProperties.SRTP.enable = toBool(details[ConfProperties::SRTP::ENABLED]);
confProperties.SRTP.rtpFallback = toBool(details[ConfProperties::SRTP::RTP_FALLBACK]);
// TLS
confProperties.TLS.listenerPort = toInt(details[ConfProperties::TLS::LISTENER_PORT]);
confProperties.TLS.enable = details[ConfProperties::TYPE] == QString(ProtocolNames::RING)
@ -1014,7 +1013,6 @@ account::ConfProperties_t::toDetails() const
? ""
: "sdes";
details[ConfProperties::SRTP::ENABLED] = toQString(this->SRTP.enable);
details[ConfProperties::SRTP::RTP_FALLBACK] = toQString(this->SRTP.rtpFallback);
// TLS
details[ConfProperties::TLS::LISTENER_PORT] = toQString(this->TLS.listenerPort);
details[ConfProperties::TLS::ENABLED] = toQString(this->TLS.enable);

1
src/libclient/api/account.h
View file

@ -159,7 +159,6 @@ struct ConfProperties_t
{
KeyExchangeProtocol keyExchange;
bool enable;
bool rtpFallback;
} SRTP;
struct TLS_t
{