accessibility: fix buttons

Fix the frameless, conversations and invitations buttons for
accessibility.

GitLab: #2049
Change-Id: I82b6722de53c40a260e706a2517aa7cb37dd99a5

src/app/commoncomponents/QWKSystemButtonGroup.qml

@@ -37,12 +37,16 @@ Row {
 
     SystemButton {
         id: minButton
+        Accessible.name: JamiStrings.minimize
+        Accessible.role: Accessible.Button
         source: JamiResources.window_bar_minimize_svg
         onClicked: appWindow.showMinimized()
     }
 
     SystemButton {
         id: maxButton
+        Accessible.name: JamiStrings.maximize
+        Accessible.role: Accessible.Button
         source: appWindow.visibility === Window.Maximized ?
                     JamiResources.window_bar_restore_svg :
                     JamiResources.window_bar_maximize_svg
@@ -53,6 +57,8 @@ Row {
 
     SystemButton {
         id: closeButton
+        Accessible.name: JamiStrings.closeApplication
+        Accessible.role: Accessible.Button
         source: JamiResources.window_bar_close_svg
         baseColor: "#e81123"
         onClicked: appWindow.close()

src/app/mainview/components/CallButtonDelegate.qml

@@ -44,12 +44,12 @@ ItemDelegate {
     Accessible.role: Accessible.Button
     Accessible.name: ItemAction.text
     Accessible.description: {
-        if (!ItemAction?.text) return ""
+        if (!ItemAction?.text)
+            return "";
         if (ItemAction.checkable) {
-            return JamiStrings.pressToToggle.arg(ItemAction.text)
+            return JamiStrings.pressToToggle.arg(ItemAction.text).arg(ItemAction.checked ? JamiStrings.active : JamiStrings.inactive);
-                .arg(ItemAction.checked ? JamiStrings.active : JamiStrings.inactive)
         }
-        return JamiStrings.pressToAction.arg(ItemAction.text)
+        return JamiStrings.pressToAction.arg(ItemAction.text);
     }
     Accessible.pressed: pressed
     Accessible.checkable: ItemAction ? ItemAction.checkable : false
@@ -198,7 +198,7 @@ ItemDelegate {
             radius: 4
         }
 
-        onActivated: index => menuAction.accept(index);
+        onActivated: index => menuAction.accept(index)
         model: visible ? menuAction.listModel : null
         delegate: ItemDelegate {
             id: menuItem
@@ -323,7 +323,6 @@ ItemDelegate {
                     // it fits within the overlay, with an extra leftward margin of 24 pixels.
                     return diff > 0 ? xValue - diff - 24 : xValue;
                 }
-
             }
 
             implicitWidth: contentItem.implicitWidth

src/app/mainview/components/FilterTabButton.qml

@@ -43,6 +43,10 @@ TabButton {
     hoverEnabled: true
     onClicked: selected()
 
+    Accessible.name: root.labelText
+    Accessible.role: Accessible.Button
+    Accessible.description: root.acceleratorSequence
+
     Rectangle {
         id: contentRect
 

src/app/net/jami/Constants/JamiStrings.qml

@@ -940,4 +940,7 @@ Item {
     property string pressToToggle: qsTr("Press to toggle %1 (%2)")
     property string active: qsTr("active")
     property string inactive: qsTr("inactive")
+    property string minimize: qsTr("Minimize application")
+    property string maximize: qsTr("Maximize application")
+    property string closeApplication: qsTr("Close application")
 }